Review main Merged

67992[BUGFIX] Adjust dataset target for Bootstrap 5 in Admin Panel

Oliver Hader CR +2 V +2 Easy +2 −2 updated 02/22/21, 16:28

Commit message

Update previous dataset attribute selector from `data-target`
to `data-bs-target` in Admin Panel preview.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oliver Hader uploaded patch set 1 02/22/21, 12:47

  2. TYPO3com voted on patch set 1 V +1 02/22/21, 12:54 Completed build in 07m 32s on Mon, 22 Feb, 12:54 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9656

  3. core-ci voted on patch set 1 V +1 02/22/21, 12:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/883

  4. Andreas Kienast voted on patch set 1 CR +1 02/22/21, 14:01

  5. Oli Bartsch commented on patch set 1 02/22/21, 14:06

    This fixes the JavaScript error but leads to the initial date is now always set to 01.01.1970.
  6. Benni Mack voted on patch set 1 V +1 CR +1 02/22/21, 14:15

  7. Benni Mack voted on patch set 1 V +2 CR +2 02/22/21, 16:28

  8. Benni Mack merged patch set 2 02/22/21, 16:28