67993[TASK] MFA providers should check their internal state
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Benjamin Franzke +1
-
Verified V +2 Done
- Benni Mack +2
- Benjamin Franzke +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 13
- typo3/sysext/backend/Classes/Controller/MfaAjaxController.php+6 −7
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php+27 −1
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php2+5 −6
- typo3/sysext/backend/Resources/Private/Language/locallang_mfa.xlf+9 −0
- typo3/sysext/backend/Resources/Private/Templates/Mfa/Setup.html2+9 −7
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/RecoveryCodes.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/RecoveryCodesProvider.php+20 −5
- typo3/sysext/core/Classes/Authentication/Mfa/Provider/TotpProvider.php+15 −5
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderManifestInterface.php+1 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaProviderPropertyManager.php+11 −1
- typo3/sysext/core/Classes/Authentication/Mfa/MfaRequiredException.php+1 −1
- typo3/sysext/core/Classes/Authentication/AbstractUserAuthentication.php+4 −4
- typo3/sysext/core/Resources/Private/Language/locallang_mfa_provider.xlf+3 −3
Review log 1222
-
Oli Bartsch uploaded patch set 1 02/22/21, 12:47
-
TYPO3com voted on patch set 1 V -1 02/22/21, 12:59 Completed build in 12m 09s on Mon, 22 Feb, 12:59 PM Test Summary: 32295 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9657
-
core-ci voted on patch set 1 V +1 02/22/21, 13:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/884
-
TYPO3com voted on patch set 1 V +1 02/22/21, 13:08 Completed build in 33m 05s on Mon, 22 Feb, 01:08 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9657
-
Benni Mack voted on patch set 1 CR +1 02/22/21, 14:56
-
Benjamin Franzke uploaded patch set 2 02/22/21, 19:12
-
Benjamin Franzke commented on patch set 2 02/22/21, 19:12
Setup.html:18The intention is to undo the display:flex effect that alert stretches the full height of the first column, right? We should rather wrap this in a `<div class="col-md-4">` and avoid inline styling. -
Benjamin Franzke commented on patch set 2 02/22/21, 19:14
Setup.html:18ReplyDone in patchset 2 (forgot to mark resolved) -
TYPO3com voted on patch set 2 V +1 02/22/21, 19:19 Completed build in 06m 59s on Mon, 22 Feb, 07:19 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9662
-
core-ci voted on patch set 2 V +1 02/22/21, 19:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/893
-
Oli Bartsch uploaded patch set 3 02/22/21, 19:34
-
Benjamin Franzke voted on patch set 3 CR +1 02/22/21, 19:39
-
TYPO3com voted on patch set 3 V +1 02/22/21, 19:42 Completed build in 07m 33s on Mon, 22 Feb, 07:42 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9663
-
core-ci voted on patch set 3 V +1 02/22/21, 19:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/894
-
Benjamin Franzke commented on patch set 3 CR -1 02/22/21, 19:52
CR -1 for now, need to perform some tests with mfa_webauthn (and maybe mfa_yubikey) regarding implicit inActive state (when number of tokens go from positiv to zero). -
Benjamin Franzke uploaded patch set 4 02/22/21, 20:06
-
TYPO3com voted on patch set 4 V -1 02/22/21, 20:16 Completed build in 09m 32s on Mon, 22 Feb, 08:16 PM Test Summary: 15572 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9664
-
core-ci voted on patch set 4 V +1 02/22/21, 20:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/895
-
TYPO3com voted on patch set 4 V +1 02/22/21, 20:33 Completed build in 10m 26s on Mon, 22 Feb, 08:33 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9666
-
Benjamin Franzke commented on patch set 4 02/22/21, 22:05
MfaInfoElement.php:71ReplyDone -
Benni Mack voted on patch set 4 V +2 CR +2 02/22/21, 22:12
-
Benni Mack merged patch set 5 02/22/21, 22:12
MfaInfoElement.php:71