Review main Merged

68032[BUGFIX] Add PHP8 compatibility to phpdocumentor packages

Benni Mack CR +2 V +2 Easy +12 −12 updated 02/22/21, 20:18

Commit message

TYPO3 already ships with latest versions for our
phpdocumentor dependencies, but in order to run
our test suite, the dependency suite is bumped
to use the latest versions that are compatible
with PHP 7.2 - PHP 8.0.

Used composer commands:
- composer require "phpdocumentor/reflection-docblock:^5.2" \
    "phpdocumentor/type-resolver:^1.3" -W
- composer require "phpdocumentor/reflection-docblock:^5.2" \
    "phpdocumentor/type-resolver:^1.3" \
     --no-update -d typo3/sysext/extbase

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 59

  1. Benni Mack uploaded patch set 1 02/22/21, 15:26

  2. Benni Mack updated the commit message in patch set 2 02/22/21, 15:28

  3. TYPO3com voted on patch set 1 V +1 02/22/21, 15:35 Completed build in 08m 26s on Mon, 22 Feb, 03:35 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9659

  4. core-ci voted on patch set 1 V +1 02/22/21, 15:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/888

  5. TYPO3com voted on patch set 2 V +1 02/22/21, 15:49 Completed build in 20m 36s on Mon, 22 Feb, 03:49 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9660

  6. core-ci voted on patch set 2 V +1 02/22/21, 15:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/890

  7. Georg Ringer voted on patch set 2 V +1 CR +1 02/22/21, 20:01

  8. Daniel Goerz voted on patch set 2 V +2 CR +2 02/22/21, 20:18

  9. Daniel Goerz merged patch set 3 02/22/21, 20:18