Review 10.4 Merged

68033[BUGFIX] Add PHP8 compatibility to phpdocumentor packages

Benni Mack CR +2 V +2 Easy +16 −16 updated 02/23/21, 07:58

Commit message

TYPO3 already ships with latest versions for our
phpdocumentor dependencies, but in order to run
our test suite, the dependency suite is bumped
to use the latest versions that are compatible
with PHP 7.2 - PHP 8.0.

Used composer commands:
- composer require "phpdocumentor/reflection-docblock:^5.2" \
    "phpdocumentor/type-resolver:^1.3" -W
- composer require "phpdocumentor/reflection-docblock:^5.2" \
    "phpdocumentor/type-resolver:^1.3" \
     --no-update -d typo3/sysext/extbase

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 511

  1. Benni Mack uploaded patch set 1 02/22/21, 15:28

  2. Benni Mack updated the commit message in patch set 2 02/22/21, 15:30

  3. TYPO3com voted on patch set 2 V +1 02/22/21, 15:43 Completed build in 10m 23s on Mon, 22 Feb, 03:43 PM Test Summary: 75341 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1119

  4. core-ci voted on patch set 1 V +1 02/22/21, 15:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/889

  5. TYPO3com voted on patch set 1 V +1 02/22/21, 15:50 Completed build in 21m 34s on Mon, 22 Feb, 03:50 PM Test Summary: 75343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1118

  6. core-ci voted on patch set 2 V +1 02/22/21, 15:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/891

  7. Daniel Goerz uploaded patch set 3 02/22/21, 20:21

  8. TYPO3com commented on patch set 3 02/22/21, 20:29 Completed build in 07m 52s on Mon, 22 Feb, 08:29 PM Test Summary: 75343 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1120

  9. core-ci commented on patch set 3 02/22/21, 20:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/897

  10. Daniel Goerz voted on patch set 3 V +2 CR +2 02/23/21, 07:58

  11. Daniel Goerz merged patch set 4 02/23/21, 07:58