Review main Merged

68052[TASK] Increase test coverage of MFA

Oli Bartsch CR +2 V +2 Expert +2214 −55 updated 03/24/21, 20:46

Commit message

This introduces various tests for the previously
introduced MFA feature and its classes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 20

Review log 2151

Show 1026 earlier messages
  1. Oli Bartsch uploaded patch set 1 02/22/21, 18:01

  2. Oli Bartsch marked it work in progress 02/22/21, 18:02

  3. TYPO3com voted on patch set 1 V +1 02/22/21, 18:08 Completed build in 06m 45s on Mon, 22 Feb, 06:08 PM Test Summary: 32719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9661

  4. core-ci voted on patch set 1 V +1 02/22/21, 18:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/892

  5. Oli Bartsch rebased onto patch set 2 03/16/21, 22:46

  6. TYPO3com voted on patch set 2 V +1 03/16/21, 22:52 Completed build in 06m 11s on Tue, 16 Mar, 10:52 PM Test Summary: 32940 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10175

  7. core-ci voted on patch set 2 V +1 03/16/21, 22:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1615

  8. Oli Bartsch uploaded patch set 3 03/17/21, 13:07

  9. TYPO3com voted on patch set 3 V +1 03/17/21, 13:14 Completed build in 06m 37s on Wed, 17 Mar, 01:14 PM Test Summary: 32949 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10189

  10. core-ci voted on patch set 3 V +1 03/17/21, 13:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1632

  11. Oli Bartsch uploaded patch set 4 03/17/21, 15:15

  12. TYPO3com voted on patch set 4 V +1 03/17/21, 15:22 Completed build in 06m 48s on Wed, 17 Mar, 03:22 PM Test Summary: 32964 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10192

  13. core-ci voted on patch set 4 V +1 03/17/21, 15:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1636

  14. Oli Bartsch uploaded patch set 5 03/17/21, 16:21

  15. TYPO3com voted on patch set 5 V +1 03/17/21, 16:29 Completed build in 08m 01s on Wed, 17 Mar, 04:29 PM Test Summary: 32974 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10193

  16. core-ci voted on patch set 5 V +1 03/17/21, 16:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1640

  17. Oli Bartsch uploaded patch set 6 03/17/21, 20:15

  18. TYPO3com voted on patch set 6 V +1 03/17/21, 20:23 Completed build in 08m 03s on Wed, 17 Mar, 08:23 PM Test Summary: 32977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10197

  19. core-ci voted on patch set 6 V +1 03/17/21, 20:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1644

  20. Oli Bartsch uploaded patch set 7 03/17/21, 22:43

  21. TYPO3com voted on patch set 7 V +1 03/17/21, 22:50 Completed build in 06m 56s on Wed, 17 Mar, 10:50 PM Test Summary: 32995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10202

  22. core-ci voted on patch set 7 V +1 03/17/21, 22:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1649

  23. Oli Bartsch uploaded patch set 8 03/17/21, 23:40

  24. TYPO3com voted on patch set 8 V +1 03/17/21, 23:46 Completed build in 06m 34s on Wed, 17 Mar, 11:46 PM Test Summary: 32994 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10203

  25. core-ci voted on patch set 8 V +1 03/17/21, 23:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1650

  26. Oli Bartsch uploaded patch set 9 03/18/21, 16:17

  1. TYPO3com voted on patch set 9 V +1 03/18/21, 16:25 Completed build in 07m 12s on Thu, 18 Mar, 04:25 PM Test Summary: 33061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10216

  2. Oli Bartsch uploaded patch set 10 03/18/21, 16:28

  3. core-ci voted on patch set 9 V +1 03/18/21, 16:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1670

  4. TYPO3com voted on patch set 10 V +1 03/18/21, 16:35 Completed build in 06m 58s on Thu, 18 Mar, 04:35 PM Test Summary: 33061 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10217

  5. core-ci voted on patch set 10 V +1 03/18/21, 16:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1671

  6. Oli Bartsch uploaded patch set 11 03/18/21, 17:28

  7. TYPO3com voted on patch set 11 V +1 03/18/21, 17:34 Completed build in 06m 20s on Thu, 18 Mar, 05:34 PM Test Summary: 33094 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10218

  8. core-ci voted on patch set 11 V +1 03/18/21, 17:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1672

  9. Oli Bartsch uploaded patch set 12 03/18/21, 18:35

  10. TYPO3com voted on patch set 12 V +1 03/18/21, 18:42 Completed build in 06m 18s on Thu, 18 Mar, 06:42 PM Test Summary: 33130 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10219

  11. core-ci voted on patch set 12 V +1 03/18/21, 18:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1673

  12. Oli Bartsch uploaded patch set 13 03/18/21, 21:34

  13. TYPO3com voted on patch set 13 V +1 03/18/21, 21:42 Completed build in 07m 53s on Thu, 18 Mar, 09:42 PM Test Summary: 33190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10221

  14. core-ci voted on patch set 13 V +1 03/18/21, 21:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1675

  15. Oli Bartsch uploaded patch set 14 03/18/21, 22:05

  16. TYPO3com voted on patch set 14 V +1 03/18/21, 22:12 Completed build in 07m 02s on Thu, 18 Mar, 10:12 PM Test Summary: 33190 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10222

  17. core-ci voted on patch set 14 V +1 03/18/21, 22:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1676

  18. Oli Bartsch marked it ready for review 03/18/21, 22:18

  19. Oli Bartsch uploaded patch set 15 03/18/21, 22:48

  20. TYPO3com voted on patch set 15 V +1 03/18/21, 22:55 Completed build in 07m 10s on Thu, 18 Mar, 10:55 PM Test Summary: 33195 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10223

  21. core-ci voted on patch set 15 V +1 03/18/21, 22:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1677

  22. Benni Mack voted on patch set 15 V +1 CR +1 03/22/21, 13:31

  23. Christian Kuhn commented on patch set 15 CR -1 03/22/21, 13:32

    -1 for the moment, will review soon.
  24. Christian Kuhn voted on patch set 15 V +2 CR +2 03/24/21, 20:45

  25. Christian Kuhn merged patch set 16 03/24/21, 20:46