Review main Merged

68056[BUGFIX] Recognize removed columns on PostgreSQL

Christian Kuhn CR +2 V +2 Easy +23 −9 updated 02/25/21, 09:16

Commit message

This patch ensures columns of tables which have been removed from
ext_tables.sql definitions are recognized on PostgreSQL so they are
renamed by adding a "zzz_deleted_" prefix.

It also enables the formerly excluded according test for SQLite
which works without additional changes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stephan Großberndt +1
    • Markus Klein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 79

  1. Christian Kuhn uploaded patch set 1 02/23/21, 10:50

  2. Christian Kuhn commented on patch set 1 02/23/21, 10:50

    re-push of https://review.typo3.org/c/Packages/TYPO3.CMS/+/67772 ... this time with mssql being excluded in the test again.
  3. TYPO3com voted on patch set 1 V +1 02/23/21, 10:56 Completed build in 06m 26s on Tue, 23 Feb, 10:56 AM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9676

  4. core-ci voted on patch set 1 V +1 02/23/21, 11:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/910

  5. Stephan Großberndt voted on patch set 1 CR +1 02/23/21, 11:02

  6. Christian Kuhn voted on patch set 1 V +1 CR +1 02/25/21, 09:09

  7. Markus Klein voted on patch set 1 V +1 CR +1 02/25/21, 09:12

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 02/25/21, 09:16

  9. Christian Kuhn merged patch set 2 02/25/21, 09:16