Review main Merged

68057[TASK] Use native Guzzle PSR-18 implementation

Benjamin Franzke CR +2 V +2 Normal +11 −223 updated 03/10/21, 22:25

Commit message

Back when the PSR-18 implementation was added in #89216 we
promised to replace our PSR-18 client wrapper once Guzzle
supports PSR-18 natively.
The intention was to point our dependency injection (DI)
alias configuration for the PSR-18 client interface to
guzzles native implementation once available.

Due to the major Guzzle update (to v7) in #92995, the PSR-18
interface implementation became available and therefore
the previous client wrapper is now dropped and DI
configuration is adapted accordingly.

We keep the existing unit tests to verify compatibility
between GuzzleHTTP client and our PSR-7 request stack.

`provide.psr/http-client-implementation` is dropped from
composer.json as this is now set by guzzlehttp/guzzle.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 3

Files 9

Review log 711

  1. Benjamin Franzke uploaded patch set 1 02/23/21, 13:07

  2. TYPO3com voted on patch set 1 V +1 02/23/21, 13:14 Completed build in 07m 06s on Tue, 23 Feb, 01:14 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9679

  3. core-ci voted on patch set 1 V +1 02/23/21, 13:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/914

  4. Daniel Goerz voted on patch set 1 CR +1 02/23/21, 13:22

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 02/23/21, 15:26

  6. Benjamin Franzke uploaded patch set 2 03/10/21, 21:23

    Resolve Merge Conflict
  7. Oli Bartsch voted on patch set 2 V +1 CR +1 03/10/21, 21:24

  8. core-ci voted on patch set 2 V +1 03/10/21, 21:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1392

  9. TYPO3com voted on patch set 2 V +1 03/10/21, 21:37 Completed build in 14m 14s on Wed, 10 Mar, 09:37 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10031

  10. Georg Ringer voted on patch set 2 V +2 CR +2 03/10/21, 22:25

  11. Georg Ringer merged patch set 3 03/10/21, 22:25