68093[BUGFIX] Use YamlFileLoader to parse form yaml configurations
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1624
-
Albrecht Köhnlein uploaded patch set 1 02/24/21, 10:11
-
Mathias Brodala commented on patch set 1 CR -1 02/24/21, 10:15
-
Albrecht Köhnlein uploaded patch set 2 02/24/21, 10:17
-
Mathias Brodala commented on patch set 2 02/24/21, 10:18
YamlSource.php:155UnresolvedThis should be dropped now that the exception is not thrown anymore. -
Ralf Zimmermann commented on patch set 1 CR -1 02/24/21, 10:18
It's not that easy. The change of the patch set would be breaking. I already have a refactoring of the configuration handling on the roadmap (including a migration to the core yaml loader), but it still takes a little time to get there. -
Ralf Zimmermann commented on patch set 2 02/24/21, 10:20
But let me test this, maybe there is a chance to not be breaking within this patchset... -
TYPO3com voted on patch set 1 V +1 02/24/21, 10:21 Completed build in 09m 30s on Wed, 24 Feb, 10:21 AM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9685
-
core-ci voted on patch set 1 V +1 02/24/21, 10:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/937
-
TYPO3com voted on patch set 2 V +1 02/24/21, 10:24 Completed build in 07m 32s on Wed, 24 Feb, 10:24 AM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9686
-
core-ci voted on patch set 2 V +1 02/24/21, 10:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/938
-
Albrecht Köhnlein commented on patch set 2 02/24/21, 10:57
Reply Unresolved
I do not see that breaking, but of course, you know the code better. 👌 Would be great, if you could give your OK, to at least have this little improvement until you finished the refactoring. 😊 -
Benni Mack uploaded patch set 3 02/24/21, 13:42
-
TYPO3com voted on patch set 3 V -1 02/24/21, 13:42 Completed build in 19s on Wed, 24 Feb, 01:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9697
-
Benni Mack uploaded patch set 4 02/24/21, 13:46
-
core-ci voted on patch set 3 V -1 02/24/21, 13:54 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/958
-
TYPO3com voted on patch set 4 V +1 02/24/21, 13:55 Completed build in 08m 41s on Wed, 24 Feb, 01:55 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9698
-
core-ci voted on patch set 4 V +1 02/24/21, 14:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/959
-
Benni Mack voted on patch set 4 CR +1 03/22/21, 18:44
-
Björn Jacob commented on patch set 4 CR -1 08/06/21, 12:04
No backport to v10 please. Let's handle it as "task". -
Oliver Hader commented on patch set 4 CR -1 08/08/21, 07:15
Allowing to use instructions like `%env(VARIABLE_NAME)%` by editors would introduce new security vulnerabilities. -
waldhacker commented on patch set 4 V -1 CR -1 08/11/21, 06:05
I'am with Olly, but @bjoern.jacob we should document that the features from https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/ApiOverview/Yaml/Index.html do not work for now in ext:form for security reasons. -
Björn Jacob commented on patch set 4 08/11/21, 08:46
Will create a new issue for documentation. IMHO let's abandon this patch. -
Benni Mack wrote 08/12/21, 10:27
Removed reviewer Benni Mack with the following votes: * Code-Review+1 by Benni Mack <benni@typo3.org> -
waldhacker abandoned the change 08/12/21, 22:51
YamlSource.php:162Unresolved