Review main Abandoned

68093[BUGFIX] Use YamlFileLoader to parse form yaml configurations

Albrecht Köhnlein CR 0 V 0 Easy +3 −22 updated 08/12/21, 22:51

Commit message

Use TYPO3's internal YamlFileLoader library to parse form yaml
configurations files.
This allows to use extended syntax, e.g. to use %env(VARIABLE_NAME)% in
form yaml files as it is shown in "TYPO3 Explained > YAML API" in
documentation and how any integrator or developer would expect TYPO3 yaml
files to work, if reads this documentation.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1624

  1. Albrecht Köhnlein uploaded patch set 1 02/24/21, 10:11

  2. Mathias Brodala commented on patch set 1 CR -1 02/24/21, 10:15

    YamlSource.php:162 Unresolved

    Please pass in "false" here since the file is not written to. This avoids temporary file copies on the local storage.
  3. Albrecht Köhnlein uploaded patch set 2 02/24/21, 10:17

  4. Mathias Brodala commented on patch set 2 02/24/21, 10:18

    YamlSource.php:155 Unresolved

    This should be dropped now that the exception is not thrown anymore.
  5. Ralf Zimmermann commented on patch set 1 CR -1 02/24/21, 10:18

    It's not that easy. The change of the patch set would be breaking. I already have a refactoring of the configuration handling on the roadmap (including a migration to the core yaml loader), but it still takes a little time to get there.
  6. Ralf Zimmermann commented on patch set 2 02/24/21, 10:20

    But let me test this, maybe there is a chance to not be breaking within this patchset...
  7. TYPO3com voted on patch set 1 V +1 02/24/21, 10:21 Completed build in 09m 30s on Wed, 24 Feb, 10:21 AM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9685

  8. core-ci voted on patch set 1 V +1 02/24/21, 10:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/937

  9. TYPO3com voted on patch set 2 V +1 02/24/21, 10:24 Completed build in 07m 32s on Wed, 24 Feb, 10:24 AM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9686

  10. core-ci voted on patch set 2 V +1 02/24/21, 10:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/938

  11. Albrecht Köhnlein commented on patch set 2 02/24/21, 10:57

    Reply Unresolved

    I do not see that breaking, but of course, you know the code better. 👌 Would be great, if you could give your OK, to at least have this little improvement until you finished the refactoring. 😊
  12. Benni Mack uploaded patch set 3 02/24/21, 13:42

  13. TYPO3com voted on patch set 3 V -1 02/24/21, 13:42 Completed build in 19s on Wed, 24 Feb, 01:42 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9697

  14. Benni Mack uploaded patch set 4 02/24/21, 13:46

  15. core-ci voted on patch set 3 V -1 02/24/21, 13:54 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/958

  16. TYPO3com voted on patch set 4 V +1 02/24/21, 13:55 Completed build in 08m 41s on Wed, 24 Feb, 01:55 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9698

  17. core-ci voted on patch set 4 V +1 02/24/21, 14:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/959

  18. Benni Mack voted on patch set 4 CR +1 03/22/21, 18:44

  19. Björn Jacob commented on patch set 4 CR -1 08/06/21, 12:04

    No backport to v10 please. Let's handle it as "task".
  20. Oliver Hader commented on patch set 4 CR -1 08/08/21, 07:15

    Allowing to use instructions like `%env(VARIABLE_NAME)%` by editors would introduce new security vulnerabilities.
  21. waldhacker commented on patch set 4 V -1 CR -1 08/11/21, 06:05

    I'am with Olly, but @bjoern.jacob we should document that the features from https://docs.typo3.org/m/typo3/reference-coreapi/10.4/en-us/ApiOverview/Yaml/Index.html do not work for now in ext:form for security reasons.
  22. Björn Jacob commented on patch set 4 08/11/21, 08:46

    Will create a new issue for documentation. IMHO let's abandon this patch.
  23. Benni Mack wrote 08/12/21, 10:27

    Removed reviewer Benni Mack with the following votes: * Code-Review+1 by Benni Mack <benni@typo3.org>
  24. waldhacker abandoned the change 08/12/21, 22:51