Review main Merged

68094[TASK] Do not require sudo mode in development context

Oli Bartsch CR +2 V +2 Normal +80 −0 updated 02/24/21, 14:52

Commit message

The sudo mode, introduced in #92836, is required whenever
the install tool is accessed in the backend.

Especially in development context accessing the install
tool is a frequent task, e.g. for clearing all caches,
to test global configuration or to run the database
analyzer.

Therefore, the sudo mode is now not longer required
while the installations application context is set
to "Development".

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Hader +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 815

  1. Oli Bartsch uploaded patch set 1 02/24/21, 10:38

  2. Oli Bartsch updated the commit message in patch set 2 02/24/21, 10:39

  3. TYPO3com voted on patch set 1 V +1 02/24/21, 10:47 Completed build in 09m 29s on Wed, 24 Feb, 10:47 AM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9687

  4. TYPO3com voted on patch set 2 V +1 02/24/21, 10:49 Completed build in 10m 25s on Wed, 24 Feb, 10:49 AM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9688

  5. core-ci voted on patch set 2 V +1 02/24/21, 10:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/940

  6. core-ci voted on patch set 1 V +1 02/24/21, 10:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/939

  7. Oli Bartsch updated the commit message in patch set 3 02/24/21, 11:20

  8. TYPO3com voted on patch set 3 V +1 02/24/21, 11:31 Completed build in 10m 15s on Wed, 24 Feb, 11:31 AM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9689

  9. core-ci voted on patch set 3 V -1 02/24/21, 11:32 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/941

  10. Oliver Hader voted on patch set 3 CR +1 02/24/21, 11:50

  11. core-ci voted on patch set 3 V +1 02/24/21, 12:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/941

  12. Benjamin Franzke voted on patch set 3 V +1 CR +1 02/24/21, 14:23

  13. Mathias Brodala voted on patch set 3 CR +1 02/24/21, 14:29

  14. Christian Kuhn voted on patch set 3 V +2 CR +2 02/24/21, 14:51

  15. Christian Kuhn merged patch set 4 02/24/21, 14:52