Review main Merged

68099[BUGFIX] Display deleted files stats for temporary processed files

Česlav Przywara CR +2 V +2 Easy +29 −0 updated 03/10/21, 21:25

Commit message

Introduce new helper method to fetch stats for temporary processed files
folder that has storage UID 0 assigned internally.

Existing public method that fetches directory stats based on storage UID
calls this helper method when necessary avoiding fatal error due to no
actual storage with UID 0 being available.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Daniel Goerz +1
    • Markus Klein +1
    • Guido Schmechel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1014

  1. Česlav Przywara uploaded patch set 1 02/24/21, 16:25

  2. TYPO3com voted on patch set 1 V -1 02/24/21, 16:25 Completed build in 27s on Wed, 24 Feb, 04:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9703

  3. core-ci voted on patch set 1 V -1 02/24/21, 16:26 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/977

  4. Česlav Przywara uploaded patch set 2 02/24/21, 16:30

  5. TYPO3com voted on patch set 2 V +1 02/24/21, 16:40 Completed build in 09m 52s on Wed, 24 Feb, 04:40 PM Test Summary: 32698 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9704

  6. core-ci voted on patch set 2 V +1 02/24/21, 16:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/978

  7. Česlav Przywara commented on patch set 2 02/24/21, 16:45

    Unresolved

    Hi guys, I'd like to ask you for review of this patch as it aims to fix an issue that I believe was caused by commit you authored/reviewed: https://github.com/TYPO3/TYPO3.CMS/commit/70a88b752b
  8. Markus Klein voted on patch set 2 V +1 CR +1 03/10/21, 16:37

  9. Daniel Goerz voted on patch set 2 CR +1 03/10/21, 17:00

  10. Guido Schmechel voted on patch set 2 CR +1 03/10/21, 18:19

  11. Andreas Kienast commented on patch set 2 V -1 03/10/21, 21:16

    Maybe I do something wrong, but after applying the patch I click the button "Delete 1 files in /typo3temp/assets/_processed_" and get the message telling me "Removed 1 files from directory "/typo3temp/assets/_processed_/"", but that's not true and the directory still contains files.
  12. Markus Klein commented on patch set 2 03/10/21, 21:19

    Reply

    Yes. But this is not related to this patch. The delete function for this specific folder is done via FAL, which does not know about your demo-file. ;-) So this is expected.
  13. Andreas Kienast commented on patch set 2 V +2 CR +2 03/10/21, 21:25

    Reply

    Thanks for clarification!
  14. Andreas Kienast merged patch set 3 03/10/21, 21:25