Review main Merged

68103[BUGFIX] Set request object in EXT:form EmailFinisher

Oli Bartsch CR +2 V +2 Easy +6 −0 updated 02/25/21, 09:40

Commit message

Because the request object was not set for the FluidEmail
variant of the EXT:form EmailFinisher, the TYPO3 logo as
well as the website URL in the footer were not displayed
when using the SystemEmail layout from Core.

This is now fixed by setting the request, if available.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Daniel Goerz +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 914

  1. Oli Bartsch uploaded patch set 1 02/25/21, 09:05

  2. Mathias Brodala commented on patch set 1 02/25/21, 09:09

    EmailFinisher.php:304

    We should add "?? null" here to avoid notices e.g. on CLI context.
  3. core-ci voted on patch set 1 V +1 02/25/21, 09:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/988

  4. Oli Bartsch uploaded patch set 2 02/25/21, 09:17

  5. Oli Bartsch commented on patch set 2 02/25/21, 09:19

    EmailFinisher.php:304 Reply

    Filling forms and sending mails on CLI, interesting. ^^
  6. TYPO3com voted on patch set 1 V +1 02/25/21, 09:19 Completed build in 13m 38s on Thu, 25 Feb, 09:19 AM Test Summary: 32704 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9711

  7. Mathias Brodala voted on patch set 2 CR +1 02/25/21, 09:20

  8. Daniel Goerz voted on patch set 2 V +1 CR +1 02/25/21, 09:28

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 02/25/21, 09:34

  10. core-ci voted on patch set 2 V +1 02/25/21, 09:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/990

  11. TYPO3com voted on patch set 2 V -1 02/25/21, 09:35 Completed build in 18m 02s on Thu, 25 Feb, 09:35 AM Test Summary: 1 of 32947 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9712

  12. TYPO3com voted on patch set 2 V +1 02/25/21, 09:39 Completed build in 39m 15s on Thu, 25 Feb, 09:39 AM Test Summary: 32706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9712

  13. Christian Kuhn voted on patch set 2 V +2 CR +2 02/25/21, 09:40

  14. Christian Kuhn merged patch set 3 02/25/21, 09:40