Review main Merged

68104[TASK] Update to Lit v2-rc1

Benjamin Franzke CR +2 V +2 Expert +837 −833 updated 04/23/21, 19:13

Commit message

Lit is the umbrella term for the next major
lit-html (v2) and lit-element (v3) versions.
Therefore we will refer to these components as
*Lit* in TYPO3 from now on as well.

These two libraries also have been migrated into
a single entry point module named `lit`.
It is officially described as:
> The main module exports the core pieces needed for component
> development: LitElement, html, css, and the most

lit-html v2 and lit-element v3 are mostly compatible
to the previous major versions. Main changes are

 * Deprecation of the `lit-element` entry point in
   favor of the new `lit` module
 * @internalProperty changed to @state
 * shadow css declaration via static property
   instead of static getter method
 * The CSSResult type declaration is gone
 * Directive (currently unused in TYPO3) API has changed

Related testing framework change is:
https://github.com/TYPO3/testing-framework/pull/229

Commands used:

  rm -rf typo3/sysext/core/Resources/Public/JavaScript/Contrib/{@lit,lit-element,lit-html,lit}/
  yarn add lit@^2.0.0-rc.1 lit-html@^2.0.0-rc.2 lit-element@^3.0.0-rc.1
  yarn add --dev rollup@^2.32.0 @rollup/plugin-replace
  grunt build
  git add typo3/sysext/core/Resources/Public/JavaScript/Contrib/{@lit,lit-element,lit-html,lit}/

  composer require --dev typo3/testing-framework:^6.8.1
  composer require --dev typo3/testing-framework:^6.8.1 \
    --no-update --working-dir=typo3/sysext/core

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
    • Benni Mack +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 142

Show 122 more files

Review log 4088

Show 2363 earlier messages
  1. Benjamin Franzke uploaded patch set 1 02/25/21, 09:52

  2. core-ci voted on patch set 1 V -1 02/25/21, 10:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/992

  3. TYPO3com voted on patch set 1 V -1 02/25/21, 10:05 Completed build in 12m 33s on Thu, 25 Feb, 10:05 AM Test Summary: 90 of 32827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9713

  4. Benjamin Franzke wrote 02/25/21, 10:22

    Topic set to lit
  5. Benjamin Franzke uploaded patch set 2 02/25/21, 12:36

  6. TYPO3com voted on patch set 2 V -1 02/25/21, 12:45 Completed build in 09m 10s on Thu, 25 Feb, 12:45 PM Test Summary: 90 of 32827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9716

  7. core-ci voted on patch set 2 V -1 02/25/21, 12:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/996

  8. Benjamin Franzke uploaded patch set 3 02/25/21, 13:06

  9. TYPO3com voted on patch set 3 V -1 02/25/21, 13:14 Completed build in 07m 22s on Thu, 25 Feb, 01:14 PM Test Summary: 90 of 32827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9717

  10. core-ci voted on patch set 3 V -1 02/25/21, 13:17 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/997

  11. Benjamin Franzke uploaded patch set 4 02/25/21, 13:35

  12. TYPO3com voted on patch set 4 V -1 02/25/21, 13:44 Completed build in 08m 50s on Thu, 25 Feb, 01:44 PM Test Summary: 90 of 32947 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9718

  13. core-ci voted on patch set 4 V +1 02/25/21, 13:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/998

  14. Benjamin Franzke uploaded patch set 5 02/25/21, 13:55

  15. TYPO3com voted on patch set 5 V -1 02/25/21, 14:03 Completed build in 07m 59s on Thu, 25 Feb, 02:03 PM Test Summary: 90 of 32947 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9719

  16. core-ci voted on patch set 5 V +1 02/25/21, 14:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/999

  17. Benjamin Franzke uploaded patch set 6 02/25/21, 15:06

  18. TYPO3com voted on patch set 6 V +1 02/25/21, 15:14 Completed build in 08m 07s on Thu, 25 Feb, 03:14 PM Test Summary: 32706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9722

  19. core-ci voted on patch set 6 V +1 02/25/21, 15:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1003

  20. Benjamin Franzke uploaded patch set 7 02/25/21, 15:22

  21. TYPO3com voted on patch set 7 V +1 02/25/21, 15:30 Completed build in 07m 36s on Thu, 25 Feb, 03:30 PM Test Summary: 32706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9723

  22. core-ci voted on patch set 7 V +1 02/25/21, 15:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1004

  23. Benjamin Franzke uploaded patch set 8 02/25/21, 15:41

  24. TYPO3com voted on patch set 8 V +1 02/25/21, 15:50 Completed build in 08m 22s on Thu, 25 Feb, 03:50 PM Test Summary: 32706 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9725

  25. core-ci voted on patch set 8 V +1 02/25/21, 15:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1006

  26. Benjamin Franzke uploaded patch set 9 02/26/21, 19:26

  27. TYPO3com voted on patch set 9 V +1 02/26/21, 19:33 Completed build in 06m 25s on Fri, 26 Feb, 07:33 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9738

  28. core-ci voted on patch set 9 V +1 02/26/21, 19:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1028

  29. Benjamin Franzke uploaded patch set 10 03/09/21, 05:54

  30. TYPO3com voted on patch set 10 V -1 03/09/21, 06:00 Completed build in 05m 37s on Tue, 9 Mar, 06:00 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9952

  31. core-ci voted on patch set 10 V -1 03/09/21, 06:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1300

  32. Benjamin Franzke uploaded patch set 11 03/09/21, 06:33

  33. TYPO3com voted on patch set 11 V +1 03/09/21, 06:38 Completed build in 05m 24s on Tue, 9 Mar, 06:38 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9953

  34. core-ci voted on patch set 11 V +1 03/09/21, 06:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1301

  35. Benjamin Franzke uploaded patch set 12 04/16/21, 20:20

  36. TYPO3com voted on patch set 12 V +1 04/16/21, 20:25 Completed build in 05m 10s on Fri, 16 Apr, 08:25 PM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10697

  37. core-ci voted on patch set 12 V +1 04/16/21, 20:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2293

  38. Benjamin Franzke uploaded patch set 13 04/17/21, 04:00

  39. TYPO3com voted on patch set 13 V +1 04/17/21, 04:07 Completed build in 07m 29s on Sat, 17 Apr, 04:07 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10699

  40. core-ci voted on patch set 13 V +1 04/17/21, 04:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2298

  41. Benjamin Franzke uploaded patch set 14 04/17/21, 04:27

  42. TYPO3com voted on patch set 14 V +1 04/17/21, 04:33 Completed build in 06m 14s on Sat, 17 Apr, 04:33 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10701

  43. core-ci voted on patch set 14 V +1 04/17/21, 04:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2300

  44. Benjamin Franzke uploaded patch set 15 04/17/21, 04:59

  45. TYPO3com voted on patch set 15 V +1 04/17/21, 05:04 Completed build in 05m 28s on Sat, 17 Apr, 05:04 AM Test Summary: 33273 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10702

  46. core-ci voted on patch set 15 V +1 04/17/21, 05:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2301

  47. Benjamin Franzke uploaded patch set 16 04/21/21, 07:06

  48. TYPO3com voted on patch set 16 V -1 04/21/21, 07:06 Completed build in 20s on Wed, 21 Apr, 07:06 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10770

  49. core-ci voted on patch set 16 V -1 04/21/21, 07:17 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2384

  50. Benjamin Franzke uploaded patch set 17 04/21/21, 07:19

  51. TYPO3com voted on patch set 17 V +1 04/21/21, 07:25 Completed build in 05m 56s on Wed, 21 Apr, 07:25 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10771

  52. core-ci voted on patch set 17 V +1 04/21/21, 07:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2385

  53. Benjamin Franzke uploaded patch set 18 04/22/21, 06:26

  54. Benjamin Franzke uploaded patch set 19 04/22/21, 06:31

  55. TYPO3com voted on patch set 18 V -1 04/22/21, 06:34 Completed build in 08m 04s on Thu, 22 Apr, 06:34 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10790

  56. TYPO3com voted on patch set 19 V +1 04/22/21, 06:38 Completed build in 06m 57s on Thu, 22 Apr, 06:38 AM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10791

  57. core-ci voted on patch set 18 V -1 04/22/21, 06:46 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10587

  58. core-ci voted on patch set 19 V +1 04/22/21, 06:54 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10588

  59. Benjamin Franzke uploaded patch set 20 04/22/21, 12:08

  60. TYPO3com voted on patch set 20 V +1 04/22/21, 12:14 Completed build in 05m 20s on Thu, 22 Apr, 12:14 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10798

  61. core-ci voted on patch set 20 V +1 04/22/21, 12:20 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10595

  62. Benjamin Franzke uploaded patch set 21 04/22/21, 12:30

  63. Benjamin Franzke commented on patch set 21 04/22/21, 12:31

    Unresolved

    Note: Specifying rollup@^2.32.0 explicitly as @rollup/plugin-replace requires rollup as peer dependency. It would work without an explicit requirement, but then yarn produces this warning: warning " > @rollup/plugin-replace@2.4.2" has unmet peer dependency "rollup@^1.20.0 || ^2.0.0". warning "@rollup/plugin-replace > @rollup/pluginutils@3.1.0" has unmet peer dependency "rollup@^1.20.0||^2.0.0". Therefore rollup@^2.32.0 is included explicitly.
  1. TYPO3com voted on patch set 21 V +1 04/22/21, 12:36 Completed build in 06m 31s on Thu, 22 Apr, 12:36 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10799

  2. core-ci voted on patch set 21 V +1 04/22/21, 12:42 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10596

  3. Benjamin Franzke uploaded patch set 22 04/23/21, 11:49

  4. Benjamin Franzke uploaded patch set 23 04/23/21, 11:56

  5. TYPO3com voted on patch set 22 V +1 04/23/21, 11:57 Completed build in 08m 01s on Fri, 23 Apr, 11:57 AM Test Summary: 33305 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10827

  6. TYPO3com voted on patch set 23 V +1 04/23/21, 12:01 Completed build in 05m 41s on Fri, 23 Apr, 12:01 PM Test Summary: 33306 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10828

  7. Oliver Hader commented on patch set 23 04/23/21, 12:24

    PageRenderer.php:1406

    Is `lit-html` kept for backward compatibility?

    RequireJSConfig.js:16

    Same question as for PageRenderer - is `lit-html` kept for BW compatibility? When can we remove it?
  8. Oliver Hader commented on patch set 23 04/23/21, 12:34

    Okay, I see... lit-html and lit-element are still around... okay
  9. Oliver Hader voted on patch set 23 V +1 CR +1 04/23/21, 12:40

  10. Benjamin Franzke commented on patch set 23 04/23/21, 12:46

    PageRenderer.php:1406 Reply Unresolved

    `lit` uses `lit-html` (and`lit-element`) under the hood, so it is actually technically required, as `lit-html` is loaded. It may be dropped in lit v3, but lit-html and lit-element will stay until then. More information also in the launch event video: https://youtu.be/f1j7b696L-E?t=959 One note: As `lit/directives/*` and `lit/decorations/*` really just re-import from `@lit/reactive-element` and `lit-html`, I thought about using requirejs aliases to optimize for less file downloads. But as they are cached by the browser and because I wanted to wait for the final release, I thought it's better to got the "vanilla" way of really loading the wrapper modules.

    RequireJSConfig.js:16 Reply

    As said above, but to be explicit, once `lit` removes the dependnecy to `lit-html` and/or `lit-element`. https://www.npmjs.com/package/lit?activeTab=dependencies
  11. Benni Mack voted on patch set 23 V +1 CR +1 04/23/21, 13:03

  12. Benjamin Franzke commented on patch set 23 CR -2 04/23/21, 13:04

    Blocking because acceptance tests are broken since https://review.typo3.org/c/Packages/TYPO3.CMS/+/68835/
  13. Benjamin Franzke rebased onto patch set 24 04/23/21, 14:30

    Rebase
  14. Benjamin Franzke voted on patch set 24 CR 0 04/23/21, 14:31

  15. Oliver Hader voted on patch set 24 V +1 CR +1 04/23/21, 14:35

  16. TYPO3com voted on patch set 24 V +1 04/23/21, 14:39 Completed build in 08m 22s on Fri, 23 Apr, 02:39 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10838

  17. core-ci voted on patch set 24 V +1 04/23/21, 14:44 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10655

  18. Oliver Hader commented on patch set 24 04/23/21, 16:21

    On it...
  19. Oliver Hader uploaded patch set 25 04/23/21, 16:24

  20. Oliver Hader voted on patch set 25 V +1 CR +1 04/23/21, 16:25

  21. TYPO3com voted on patch set 25 V +1 04/23/21, 16:31 Completed build in 06m 36s on Fri, 23 Apr, 04:31 PM Test Summary: 33307 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10844

  22. core-ci voted on patch set 25 V +1 04/23/21, 16:34 Core CI is happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/10661

  23. Benni Mack voted on patch set 25 V +1 CR +1 04/23/21, 18:09

  24. Benjamin Franzke voted on patch set 25 V +2 CR +2 04/23/21, 19:11

  25. Benjamin Franzke merged patch set 26 04/23/21, 19:13