68109[BUGFIX] Enforce closing tags in Fluid f:form.button ViewHelper
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Simon Gilli +1
-
Verified V +2 Done
- Christian Kuhn +2
- Simon Gilli +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Oli Bartsch uploaded patch set 1 02/25/21, 14:47
-
Simon Gilli voted on patch set 1 CR +1 02/25/21, 14:49
-
TYPO3com voted on patch set 1 V +1 02/25/21, 14:55 Completed build in 07m 51s on Thu, 25 Feb, 02:55 PM Test Summary: 32708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9721
-
core-ci voted on patch set 1 V +1 02/25/21, 15:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1002
-
Christian Kuhn commented on patch set 1 V +1 CR +1 02/25/21, 15:43
waiting for some opinion on v10 backport for this ... not 100% sure yet. -
Simon Gilli voted on patch set 1 V +1 02/25/21, 15:49
-
Simon Gilli commented on patch set 1 02/25/21, 15:51
Reply
What's the reason you're not sure here? Imho does not hurt and fixes an issue. -
Christian Kuhn commented on patch set 1 02/25/21, 16:01
Reply Unresolved
right. got similar feedback on slack. -
Christian Kuhn voted on patch set 1 V +2 CR +2 02/25/21, 16:04
-
Christian Kuhn merged patch set 2 02/25/21, 16:04