Review main Merged

68109[BUGFIX] Enforce closing tags in Fluid f:form.button ViewHelper

Oli Bartsch CR +2 V +2 Easy +25 −0 updated 02/25/21, 16:04

Commit message

It's mandatory for HTML button elements to provide both,
the starting and the ending tag, even if no phrasing content
is provided.

See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button

This is now enforced in the corresponding ViewHelper.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Oli Bartsch uploaded patch set 1 02/25/21, 14:47

  2. Simon Gilli voted on patch set 1 CR +1 02/25/21, 14:49

  3. TYPO3com voted on patch set 1 V +1 02/25/21, 14:55 Completed build in 07m 51s on Thu, 25 Feb, 02:55 PM Test Summary: 32708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9721

  4. core-ci voted on patch set 1 V +1 02/25/21, 15:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1002

  5. Christian Kuhn commented on patch set 1 V +1 CR +1 02/25/21, 15:43

    waiting for some opinion on v10 backport for this ... not 100% sure yet.
  6. Simon Gilli voted on patch set 1 V +1 02/25/21, 15:49

  7. Simon Gilli commented on patch set 1 02/25/21, 15:51

    Reply

    What's the reason you're not sure here? Imho does not hurt and fixes an issue.
  8. Christian Kuhn commented on patch set 1 02/25/21, 16:01

    Reply Unresolved

    right. got similar feedback on slack.
  9. Christian Kuhn voted on patch set 1 V +2 CR +2 02/25/21, 16:04

  10. Christian Kuhn merged patch set 2 02/25/21, 16:04