Review main Merged

68111[FEATURE] Allow group id lookup in TS conditions with array operator

Martin Kutschker CR +2 V +2 Normal +74 −1 updated 03/12/21, 12:58

Commit message

In the backend and frontend the array of user group ids of the current backend user
is now available as backend.user.userGroupIds. In the frontend the the array of
user group ids of the current frontend user is available as frontend.user.userGroupIds.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1121

  1. Martin Kutschker uploaded patch set 1 02/25/21, 19:14

  2. core-ci voted on patch set 1 V +1 02/25/21, 19:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1017

  3. TYPO3com voted on patch set 1 V +1 02/25/21, 19:27 Completed build in 12m 48s on Thu, 25 Feb, 07:27 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9733

  4. Mathias Brodala commented on patch set 1 CR -1 02/26/21, 07:32

    Can you add these to the BE/FE ConditionMatcherTest?

    Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst:20

    Can you make this a TypoScript code block (https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/WritingReST/Codeblocks.html) and add a backend example for completeness?

    ConditionMatcher.php:75

    This must be "userGroupIds" instead.
  5. Martin Kutschker uploaded patch set 2 02/26/21, 17:44

  6. Martin Kutschker commented on patch set 2 02/26/21, 17:45

    Reply

    Yes.

    Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst:20 Reply

    Done

    ConditionMatcher.php:75 Reply

    Done
  7. TYPO3com voted on patch set 2 V -1 02/26/21, 17:51 Completed build in 06m 33s on Fri, 26 Feb, 05:51 PM Test Summary: 3 of 32978 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9737

  8. core-ci voted on patch set 2 V -1 02/26/21, 17:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1027

  9. Martin Kutschker uploaded patch set 3 02/26/21, 21:19

  10. TYPO3com voted on patch set 3 V +1 02/26/21, 21:26 Completed build in 07m 01s on Fri, 26 Feb, 09:26 PM Test Summary: 32737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9741

  11. core-ci voted on patch set 3 V +1 02/26/21, 21:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1031

  12. Georg Ringer updated the commit message in patch set 4 03/02/21, 19:29

  13. TYPO3com voted on patch set 4 V +1 03/02/21, 19:36 Completed build in 06m 57s on Tue, 2 Mar, 07:36 PM Test Summary: 32737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9817

  14. core-ci voted on patch set 4 V -1 03/02/21, 19:41 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1132

  15. Martin Kutschker rebased onto patch set 5 03/02/21, 20:17

  16. TYPO3com voted on patch set 5 V +1 03/02/21, 20:28 Completed build in 10m 02s on Tue, 2 Mar, 08:28 PM Test Summary: 32739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9820

  17. core-ci voted on patch set 5 V +1 03/02/21, 20:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1136

  18. Benni Mack voted on patch set 5 V +1 CR +1 03/11/21, 20:12

  19. Oli Bartsch voted on patch set 5 V +1 CR +1 03/12/21, 10:54

  20. Benni Mack voted on patch set 5 V +2 CR +2 03/12/21, 12:58

  21. Benni Mack merged patch set 6 03/12/21, 12:58