68111[FEATURE] Allow group id lookup in TS conditions with array operator
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php+1 −0
- typo3/sysext/backend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+11 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst2new+31 −0
- typo3/sysext/frontend/Classes/Configuration/TypoScript/ConditionMatching/ConditionMatcher.php2+2 −0
- typo3/sysext/frontend/Tests/Functional/Configuration/TypoScript/ConditionMatching/ConditionMatcherTest.php+29 −1
Review log 1121
-
Martin Kutschker uploaded patch set 1 02/25/21, 19:14
-
core-ci voted on patch set 1 V +1 02/25/21, 19:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1017
-
TYPO3com voted on patch set 1 V +1 02/25/21, 19:27 Completed build in 12m 48s on Thu, 25 Feb, 07:27 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9733
-
Mathias Brodala commented on patch set 1 CR -1 02/26/21, 07:32
Can you add these to the BE/FE ConditionMatcherTest?Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst:20Can you make this a TypoScript code block (https://docs.typo3.org/m/typo3/docs-how-to-document/master/en-us/WritingReST/Codeblocks.html) and add a backend example for completeness?ConditionMatcher.php:75This must be "userGroupIds" instead. -
Martin Kutschker uploaded patch set 2 02/26/21, 17:44
-
Martin Kutschker commented on patch set 2 02/26/21, 17:45
Reply
Yes.Feature-93591-AllowGroupIdLookupInConditionsWithArrayOperator.rst:20ReplyDoneConditionMatcher.php:75ReplyDone -
TYPO3com voted on patch set 2 V -1 02/26/21, 17:51 Completed build in 06m 33s on Fri, 26 Feb, 05:51 PM Test Summary: 3 of 32978 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9737
-
core-ci voted on patch set 2 V -1 02/26/21, 17:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1027
-
Martin Kutschker uploaded patch set 3 02/26/21, 21:19
-
TYPO3com voted on patch set 3 V +1 02/26/21, 21:26 Completed build in 07m 01s on Fri, 26 Feb, 09:26 PM Test Summary: 32737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9741
-
core-ci voted on patch set 3 V +1 02/26/21, 21:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1031
-
Georg Ringer updated the commit message in patch set 4 03/02/21, 19:29
-
TYPO3com voted on patch set 4 V +1 03/02/21, 19:36 Completed build in 06m 57s on Tue, 2 Mar, 07:36 PM Test Summary: 32737 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9817
-
core-ci voted on patch set 4 V -1 03/02/21, 19:41 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1132
-
Martin Kutschker rebased onto patch set 5 03/02/21, 20:17
-
TYPO3com voted on patch set 5 V +1 03/02/21, 20:28 Completed build in 10m 02s on Tue, 2 Mar, 08:28 PM Test Summary: 32739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9820
-
core-ci voted on patch set 5 V +1 03/02/21, 20:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1136
-
Benni Mack voted on patch set 5 V +1 CR +1 03/11/21, 20:12
-
Oli Bartsch voted on patch set 5 V +1 CR +1 03/12/21, 10:54
-
Benni Mack voted on patch set 5 V +2 CR +2 03/12/21, 12:58
-
Benni Mack merged patch set 6 03/12/21, 12:58