Review 10.4 Merged

68117[TASK] Replace string parsing in Message with unpack

Christian Kuhn CR +2 V +2 Easy +20 −19 updated 02/25/21, 17:21

Commit message

Replaces an inefficient string parsing using strlen, for
and ord, to use unpack instead. Saves one call to strlen
per header, and potentially thousands of calls to ord
per request.

The same strategy is used in Message->filter, however,
this method does not appear to be used so the unpack
change is only applied in isValidHeaderValue.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Christian Kuhn commented on patch set 1 02/25/21, 17:01

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/25/21, 17:13 Completed build in 11m 10s on Thu, 25 Feb, 05:13 PM Test Summary: 75427 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1136

  3. core-ci voted on patch set 1 V +1 02/25/21, 17:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1012

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/25/21, 17:20

  5. Christian Kuhn merged patch set 2 02/25/21, 17:21