Review main Merged

68135[TASK] Drop an always skipped unit test

Christian Kuhn CR +2 V +2 Normal +1 −57 updated 02/27/21, 08:53

Commit message

* Test relies on xdebug, which is not available on CI, this
  test is never executed there.
* Since the low level API header() is tested, the test
  additionally needs to fork a php process to do it's thing.
  This is ugly for a unit test.
* Turning the test into a functional test won't improve the
  situation since the response emitting is not done with
  functional sub requests.
* The skip logic breaks with xdebug 3.0 using xdebug.mode=off.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Simon Gilli +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Simon Gilli +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Christian Kuhn uploaded patch set 1 02/27/21, 07:37

  2. TYPO3com voted on patch set 1 V +1 02/27/21, 07:44 Completed build in 06m 35s on Sat, 27 Feb, 07:44 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9742

  3. core-ci voted on patch set 1 V +1 02/27/21, 07:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1035

  4. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/27/21, 07:52

  5. Christian Kuhn updated the commit message in patch set 2 02/27/21, 08:27

  6. Simon Gilli voted on patch set 2 V +1 CR +1 02/27/21, 08:30

  7. Markus Klein voted on patch set 2 V +1 CR +1 02/27/21, 08:31

  8. TYPO3com voted on patch set 2 V +1 02/27/21, 08:34 Completed build in 06m 54s on Sat, 27 Feb, 08:34 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9743

  9. Anja Leichsenring voted on patch set 2 V +1 CR +1 02/27/21, 08:35

  10. core-ci voted on patch set 2 V +1 02/27/21, 08:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1036

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 02/27/21, 08:52

  12. Christian Kuhn merged patch set 3 02/27/21, 08:53