Review 9.5 Merged

68136[TASK] Drop an always skipped unit test

Christian Kuhn CR +2 V +2 Easy +1 −43 updated 02/27/21, 09:21

Commit message

* Test relies on xdebug, which is not available on CI, this
  test is never executed there.
* Since the low level API header() is tested, the test
  additionally needs to fork a php process to do it's thing.
  This is ugly for a unit test.
* Turning the test into a functional test won't improve the
  situation since the response emitting is not done with
  functional sub requests.
* The skip logic breaks with xdebug 3.0 using xdebug.mode=off.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Christian Kuhn uploaded patch set 1 02/27/21, 08:55

  2. TYPO3com voted on patch set 1 V +1 02/27/21, 09:09 Completed build in 13m 11s on Sat, 27 Feb, 09:09 AM Test Summary: 75298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1009

  3. core-ci voted on patch set 1 V +1 02/27/21, 09:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1040

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 02/27/21, 09:21

  5. Christian Kuhn merged patch set 2 02/27/21, 09:21