Review main Merged

68137[TASK] Deal with xdebug 3

Christian Kuhn CR +2 V +2 Normal +68 −47 updated 02/27/21, 17:34

Commit message

Adapt testing related docker-compose.yml to properly
work with xdebug 3.0. This is packaged in the testing
container images already and is the only version
compatible with PHP 8.

To spice up developers life, xdebug 3.0 drops important
config options in a non b/w compatible way, introduces
new ones, where some of them overwrite others, and does
further stuff like changing the default step debugger
port for no apparent reason.

Since xdebug can be such a pain, runTests.sh comes with
-x option, so it (hopefully) 'just works' for devs using
the script in testing context. The setup of course breaks
with xdebug 3.0 and is fixed with the patch.

As single advantage, it is now easier to disable xdebug,
so the 'prepared php.ini file without xdebug' hack in
the test container images can be dropped.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Simon Gilli +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 818

  1. Christian Kuhn uploaded patch set 1 02/27/21, 10:50

  2. TYPO3com voted on patch set 1 V -1 02/27/21, 10:57 Completed build in 07m 13s on Sat, 27 Feb, 10:57 AM Test Summary: 1 of 32967 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9748

  3. TYPO3com commented on patch set 1 02/27/21, 11:00 Completed build in 17m 17s on Sat, 27 Feb, 11:00 AM Test Summary: 1 of 32967 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9748

  4. core-ci voted on patch set 1 V +1 02/27/21, 11:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1042

  5. TYPO3com voted on patch set 1 V +1 02/27/21, 11:07 Completed build in 33m 46s on Sat, 27 Feb, 11:07 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9748

  6. Christian Kuhn updated the commit message in patch set 2 02/27/21, 11:22

  7. Christian Kuhn updated the commit message in patch set 3 02/27/21, 11:27

  8. TYPO3com voted on patch set 2 V +1 02/27/21, 11:30 Completed build in 07m 40s on Sat, 27 Feb, 11:30 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9749

  9. Christian Kuhn uploaded patch set 4 02/27/21, 11:33

  10. core-ci voted on patch set 2 V +1 02/27/21, 11:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1043

  11. TYPO3com voted on patch set 3 V +1 02/27/21, 11:35 Completed build in 08m 03s on Sat, 27 Feb, 11:35 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9750

  12. core-ci voted on patch set 3 V +1 02/27/21, 11:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1044

  13. TYPO3com voted on patch set 4 V +1 02/27/21, 11:41 Completed build in 07m 04s on Sat, 27 Feb, 11:41 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9751

  14. Simon Gilli voted on patch set 4 V +1 CR +1 02/27/21, 11:44

  15. core-ci voted on patch set 4 V +1 02/27/21, 11:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1045

  16. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/27/21, 17:29

  17. Christian Kuhn voted on patch set 4 V +2 CR +2 02/27/21, 17:34

  18. Christian Kuhn merged patch set 5 02/27/21, 17:34