Review 9.5 Merged

68142[TASK] Deal with xdebug 3

Christian Kuhn CR +2 V +2 Normal +65 −44 updated 02/27/21, 22:59

Commit message

Adapt testing related docker-compose.yml to properly
work with xdebug 3.0. This is packaged in the testing
container images already and is the only version
compatible with PHP 8.

To spice up developers life, xdebug 3.0 drops important
config options in a non b/w compatible way, introduces
new ones, where some of them overwrite others, and does
further stuff like changing the default step debugger
port for no apparent reason.

Since xdebug can be such a pain, runTests.sh comes with
-x option, so it (hopefully) 'just works' for devs using
the script in testing context. The setup of course breaks
with xdebug 3.0 and is fixed with the patch.

As single advantage, it is now easier to disable xdebug,
so the 'prepared php.ini file without xdebug' hack in
the test container images can be dropped.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 48

  1. Christian Kuhn uploaded patch set 1 02/27/21, 22:04

  2. TYPO3com voted on patch set 1 V +1 02/27/21, 22:16 Completed build in 11m 29s on Sat, 27 Feb, 10:16 PM Test Summary: 75298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1010

  3. core-ci voted on patch set 1 V +1 02/27/21, 22:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1052

  4. Christian Kuhn updated the commit message in patch set 2 02/27/21, 22:36

  5. TYPO3com voted on patch set 2 V +1 02/27/21, 22:46 Completed build in 09m 17s on Sat, 27 Feb, 10:46 PM Test Summary: 75296 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1011

  6. core-ci voted on patch set 2 V +1 02/27/21, 22:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1053

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 02/27/21, 22:58

  8. Christian Kuhn merged patch set 3 02/27/21, 22:59