Review main Merged

68151[TASK] Integrate Pagetree acceptance suite into Backend suite

Anja Leichsenring CR +2 V +2 Hard +121 −389 updated 04/10/22, 07:09

Commit message

The Pagetree suite for acceptance tests was set up as a separate
suite in the beginning due to a necessary fixture set of pages,
that all the other tests don't need.
The overhead of having separate suite is higher than the additional
fixture set, so the suites are merged.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 16

Review log 1020

  1. Anja Leichsenring uploaded patch set 1 02/28/21, 19:38

  2. TYPO3com voted on patch set 1 V -1 02/28/21, 19:38 Completed build in 19s on Sun, 28 Feb, 07:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9769

  3. core-ci voted on patch set 1 V -1 02/28/21, 19:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1070

  4. Anja Leichsenring uploaded patch set 2 02/28/21, 19:43

  5. Anja Leichsenring uploaded patch set 3 02/28/21, 19:47

  6. TYPO3com voted on patch set 2 V -1 02/28/21, 19:50 Completed build in 07m 17s on Sun, 28 Feb, 07:50 PM Test Summary: 2 of 32967 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9770

  7. TYPO3com voted on patch set 3 V -1 02/28/21, 19:55 Completed build in 07m 59s on Sun, 28 Feb, 07:55 PM Test Summary: 2 of 32967 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9771

  8. core-ci voted on patch set 2 V -1 02/28/21, 19:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1071

  9. core-ci voted on patch set 3 V -1 02/28/21, 20:01 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1072

  10. Anja Leichsenring uploaded patch set 4 02/28/21, 20:17

  11. TYPO3com voted on patch set 4 V -1 02/28/21, 20:24 Completed build in 06m 42s on Sun, 28 Feb, 08:24 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9772

  12. core-ci voted on patch set 4 V +1 02/28/21, 20:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1073

  13. Richard Haeser commented on patch set 4 V +1 CR +1 03/01/21, 10:20

    The bamboo suite that is failing is the one that gets removed. So I guess that is the issue why it is failing.
  14. Christian Kuhn rebased onto patch set 5 03/01/21, 10:58

  15. TYPO3com voted on patch set 5 V +1 03/01/21, 11:05 Completed build in 06m 20s on Mon, 1 Mar, 11:05 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9775

  16. core-ci voted on patch set 5 V +1 03/01/21, 11:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1079

  17. Richard Haeser voted on patch set 5 V +1 CR +1 03/01/21, 11:10

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 03/01/21, 11:46

  19. Christian Kuhn merged patch set 6 03/01/21, 11:46

  20. Oliver Hader commented on patch set 6 04/08/22, 13:28

    SelectPagetreeWithKeyboardCest.php:170 Unresolved