Review main Merged

68152[BUGFIX] Load FlexForm Sections on new before save

Tomas Norre Mikkelsen CR +2 V +2 Easy +18 −0 updated 11/10/21, 18:15

Commit message

FlexForm Section can be added before content element is saved.
This is done by ensuring that processedTca have a value for list_type.

Earlier the pi_flexform was ignored as the default values on create
before save was empty.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2128

Show 13 earlier messages
  1. Tomas Norre Mikkelsen uploaded patch set 1 03/01/21, 08:15

  2. TYPO3com voted on patch set 1 V +1 03/01/21, 08:22 Completed build in 06m 40s on Mon, 1 Mar, 08:22 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9773

  3. core-ci voted on patch set 1 V +1 03/01/21, 08:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1077

  1. Mattias Nilsson voted on patch set 1 CR +1 03/29/21, 06:46

  2. Benni Mack commented on patch set 1 11/04/21, 11:21

    FormFlexAjaxController.php:84

    do we need the comment still?
  3. Tomas Norre Mikkelsen commented on patch set 1 11/04/21, 14:19

    FormFlexAjaxController.php:84 Reply

    I think the comment isn't relevant directly, as I was a note if it could be done smarter.
  4. Oli Bartsch updated the commit message in patch set 2 11/08/21, 17:25

  5. core-ci voted on patch set 2 V +1 11/08/21, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19033

  6. Oli Bartsch commented on patch set 2 CR -1 11/08/21, 23:25

    Will update shortly.

    FormFlexAjaxController.php:90

    This is not always defined. An easy to test example is felogin_login, which uses flexform but does not use the subtype feature, since it is a dedicated CType.
  7. Oli Bartsch uploaded patch set 3 11/08/21, 23:49

  8. Oli Bartsch uploaded patch set 4 11/08/21, 23:58

  9. core-ci voted on patch set 3 V -1 11/09/21, 01:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19052

  10. core-ci voted on patch set 4 V -1 11/09/21, 02:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19053

  11. Oli Bartsch rebased onto patch set 5 11/09/21, 08:59

  12. core-ci voted on patch set 5 V +1 11/09/21, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19060

  13. Oli Bartsch commented on patch set 5 V +1 CR +1 11/09/21, 09:22

    FormFlexAjaxController.php:84 Reply

    Done

    FormFlexAjaxController.php:90 Reply

    Done
  14. Benni Mack voted on patch set 5 V +1 CR +1 11/09/21, 12:49

  15. Christian Kuhn voted on patch set 5 CR -1 11/09/21, 13:17

  16. Christian Kuhn commented on patch set 5 11/09/21, 13:32

    starred this change and promise to work on that soon (tm).
  17. Christian Kuhn commented on patch set 5 11/09/21, 13:37

    FormFlexAjaxController.php:92

    This is kinda unfortunate since this uses the 'internal' dataStructureKey of type=tca dataStructureIdentifier's to solve things. This won't work when the two flexFormTools methods are enriched with hooks, for instance, and I would prefer some different solution. I'd like to give this some thoughts, it might be unavoidable to do it this way, but we should have a more detailed look and at least explain the situation more detailed in a comment. Also, the key access to dataStructureKey at least needs a null coalescence fallback, or type=tca should be checked.
  18. Christian Kuhn uploaded patch set 6 11/10/21, 17:52

  19. Christian Kuhn commented on patch set 6 V +1 CR +1 11/10/21, 17:54

    Ok. Had some thoughts on this. The solution is still a hack and I added an according comment now. But, considering the fact that we'd rather like to get rid of sub types anyway, this is the easiest solution for now that does not require bigger refactoring for a system that may vanish again. imho good to go. Thanks for your works!
  20. Christian Kuhn commented on patch set 6 11/10/21, 17:55

    FormFlexAjaxController.php:92 Reply

    Done
  21. core-ci voted on patch set 6 V +1 11/10/21, 18:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19136

  22. Benni Mack voted on patch set 6 V +1 CR +1 11/10/21, 18:11

  23. Oli Bartsch voted on patch set 6 V +1 CR +1 11/10/21, 18:14

  24. Christian Kuhn voted on patch set 6 V +2 CR +2 11/10/21, 18:15

  25. Christian Kuhn merged patch set 7 11/10/21, 18:15