Review main Merged

68153[BUGFIX] Add rowSum to runThroughTemplatesPostProcessing hook parameters

Jigal van Hemert CR +2 V +2 Easy +1 −0 updated 03/01/21, 19:25

Commit message

If the hook is used to add TypoScript, information must also be
added to the rowSum array in order to generate correct cache keys.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 611

  1. Jigal van Hemert uploaded patch set 1 03/01/21, 10:38

  2. TYPO3com voted on patch set 1 V -1 03/01/21, 10:44 Completed build in 06m 12s on Mon, 1 Mar, 10:44 AM Test Summary: 1 of 32967 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9774

  3. core-ci voted on patch set 1 V +1 03/01/21, 10:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1078

  4. TYPO3com voted on patch set 1 V +1 03/01/21, 16:21 Completed build in 5h 48m 48s on Mon, 1 Mar, 04:21 PM Test Summary: 32716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9774

  5. Christian Kuhn updated the commit message in patch set 2 03/01/21, 16:23

  6. Christian Kuhn voted on patch set 2 CR +1 03/01/21, 16:23

  7. TYPO3com voted on patch set 2 V +1 03/01/21, 16:30 Completed build in 06m 38s on Mon, 1 Mar, 04:30 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9784

  8. core-ci voted on patch set 2 V +1 03/01/21, 16:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1090

  9. Christian Kuhn voted on patch set 2 V +1 03/01/21, 19:24

  10. Benni Mack voted on patch set 2 V +2 CR +2 03/01/21, 19:24

  11. Benni Mack merged patch set 3 03/01/21, 19:25