68155[TASK] Do not unserialize stdClass of be_users.uc in extensionmanager
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 1
Review log 1115
-
Stephan Großberndt uploaded patch set 1 03/01/21, 12:06
-
TYPO3com voted on patch set 1 V +1 03/01/21, 12:13 Completed build in 06m 36s on Mon, 1 Mar, 12:13 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9779
-
core-ci voted on patch set 1 V +1 03/01/21, 12:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1083
-
Christian Kuhn commented on patch set 1 03/01/21, 15:47
imho safe. will wait for another opinion before vote, though. -
Oliver Hader commented on patch set 1 03/01/21, 16:56
Ok, I don't see security implications for `\stdClass`... So, is this really a "bugfix" or more like a "task/hardening" thingy? In the past we had https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5.x/Important-89269-IntroduceUpgradeWizardForInvalidBackendUserConfiguration.html Thus, `\stdClass` should(!) not be used anymore - I did not verify that - at least for `11.x` it seems to be fine to adjust that. -
Christian Kuhn commented on patch set 1 03/01/21, 17:06
Reply
so change in master only to be on the safe side? -
Oliver Hader commented on patch set 1 03/01/21, 17:16
Reply
Probably fine for 10.4 as well - as mentioned: I did not check/verify the code for BE_USER->uc. However, still I'd like to understand the "bug" first. Where is `stdClass` coming from in this context? -
Christian Kuhn commented on patch set 1 03/01/21, 17:29
Reply
I suppose it has been introduced rather accidentally with https://review.typo3.org/c/Packages/TYPO3.CMS/+/62595/5/typo3/sysext/extensionmanager/Classes/Controller/ListController.php -
Stephan Großberndt updated the commit message in patch set 2 03/01/21, 18:43
-
Stephan Großberndt commented on patch set 2 03/01/21, 18:49
Reply
I think so too. Maybe Michael still knows? All other locations in core where uc is unserialized, especially AbstractUserAuthentication with write/unpack do not allow any class. this change is rather for consistency. also see https://typo3.slack.com/archives/C03AM9R17/p1614598133076800?thread_ts=1614598133.076800&cid=C03AM9R17 -
TYPO3com voted on patch set 2 V +1 03/01/21, 18:50 Completed build in 07m 11s on Mon, 1 Mar, 06:50 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9788
-
core-ci voted on patch set 2 V +1 03/01/21, 18:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1096
-
Benni Mack voted on patch set 2 V +1 CR +1 03/01/21, 19:26
-
Christian Kuhn voted on patch set 2 V +2 CR +2 03/01/21, 19:27
-
Christian Kuhn merged patch set 3 03/01/21, 19:29