Review main Merged

68155[TASK] Do not unserialize stdClass of be_users.uc in extensionmanager

Stephan Großberndt CR +2 V +2 Easy +1 −1 updated 03/01/21, 19:29

Commit message

This patch changes the behaviour when saving the backendfilter in
extensionmanager list to not allow any class unserialize as TYPO3 Core
does not put any classes in the UC and no other place in Core allows
to unserialize stdClass for be_users.uc.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Stephan Großberndt uploaded patch set 1 03/01/21, 12:06

  2. TYPO3com voted on patch set 1 V +1 03/01/21, 12:13 Completed build in 06m 36s on Mon, 1 Mar, 12:13 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9779

  3. core-ci voted on patch set 1 V +1 03/01/21, 12:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1083

  4. Christian Kuhn commented on patch set 1 03/01/21, 15:47

    imho safe. will wait for another opinion before vote, though.
  5. Oliver Hader commented on patch set 1 03/01/21, 16:56

    Ok, I don't see security implications for `\stdClass`... So, is this really a "bugfix" or more like a "task/hardening" thingy? In the past we had https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.5.x/Important-89269-IntroduceUpgradeWizardForInvalidBackendUserConfiguration.html Thus, `\stdClass` should(!) not be used anymore - I did not verify that - at least for `11.x` it seems to be fine to adjust that.
  6. Christian Kuhn commented on patch set 1 03/01/21, 17:06

    Reply

    so change in master only to be on the safe side?
  7. Oliver Hader commented on patch set 1 03/01/21, 17:16

    Reply

    Probably fine for 10.4 as well - as mentioned: I did not check/verify the code for BE_USER->uc. However, still I'd like to understand the "bug" first. Where is `stdClass` coming from in this context?
  8. Christian Kuhn commented on patch set 1 03/01/21, 17:29

  9. Stephan Großberndt updated the commit message in patch set 2 03/01/21, 18:43

  10. Stephan Großberndt commented on patch set 2 03/01/21, 18:49

    Reply

    I think so too. Maybe Michael still knows? All other locations in core where uc is unserialized, especially AbstractUserAuthentication with write/unpack do not allow any class. this change is rather for consistency. also see https://typo3.slack.com/archives/C03AM9R17/p1614598133076800?thread_ts=1614598133.076800&cid=C03AM9R17
  11. TYPO3com voted on patch set 2 V +1 03/01/21, 18:50 Completed build in 07m 11s on Mon, 1 Mar, 06:50 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9788

  12. core-ci voted on patch set 2 V +1 03/01/21, 18:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1096

  13. Benni Mack voted on patch set 2 V +1 CR +1 03/01/21, 19:26

  14. Christian Kuhn voted on patch set 2 V +2 CR +2 03/01/21, 19:27

  15. Christian Kuhn merged patch set 3 03/01/21, 19:29