Review main Merged

68156[BUGFIX] Show diff for new and delete placeholder records

Oli Bartsch CR +2 V +2 Normal +76 −1 updated 03/02/21, 20:50

Commit message

The workspace module features the element information modal,
which displays, next to the record history, the current version
records' difference to its live record. This difference is now
also displayed for new and delete placeholder records. It's not
reasonable forcing the user to always open the complete record
to have a quick look at the values of e.g. a new record.

Since new / delete placeholders basically contain all fields,
defined in TCA, they are filtered using the FormDataCompiler
to only show the suitable ones.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 715

  1. Oli Bartsch uploaded patch set 1 03/01/21, 14:54

  2. TYPO3com voted on patch set 1 V +1 03/01/21, 15:02 Completed build in 07m 18s on Mon, 1 Mar, 03:02 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9781

  3. core-ci voted on patch set 1 V +1 03/01/21, 15:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1085

  4. Oli Bartsch uploaded patch set 2 03/02/21, 11:54

  5. TYPO3com voted on patch set 2 V -1 03/02/21, 12:04 Completed build in 10m 30s on Tue, 2 Mar, 12:04 PM Test Summary: 790 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9804

  6. core-ci voted on patch set 2 V +1 03/02/21, 12:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1117

  7. Oli Bartsch uploaded patch set 3 03/02/21, 13:26

  8. TYPO3com voted on patch set 3 V +1 03/02/21, 13:34 Completed build in 07m 17s on Tue, 2 Mar, 01:34 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9806

  9. core-ci voted on patch set 3 V +1 03/02/21, 13:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1120

  10. Christian Kuhn updated the commit message in patch set 4 03/02/21, 17:42

  11. Christian Kuhn voted on patch set 4 V +1 CR +1 03/02/21, 17:44

  12. TYPO3com voted on patch set 4 V +1 03/02/21, 17:49 Completed build in 06m 38s on Tue, 2 Mar, 05:49 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9810

  13. core-ci voted on patch set 4 V +1 03/02/21, 17:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1125

  14. Benni Mack voted on patch set 4 V +2 CR +2 03/02/21, 20:50

  15. Benni Mack merged patch set 5 03/02/21, 20:50