Review 10.4 Merged

68157[BUGFIX] Show diff for new and delete placeholder records

Oli Bartsch CR +2 V +2 Normal +76 −1 updated 03/02/21, 20:50

Commit message

The workspace module features the element information modal,
which displays, next to the record history, the current version
records' difference to its live record. This difference is now
also displayed for new and delete placeholder records. It's not
reasonable forcing the user to always open the complete record
to have a quick look at the values of e.g. a new record.

Since new / delete placeholders basically contain all fields,
defined in TCA, they are filtered using the FormDataCompiler
to only show the suitable ones.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 816

  1. Oli Bartsch uploaded patch set 1 03/01/21, 14:54

  2. TYPO3com voted on patch set 1 V +1 03/01/21, 15:06 Completed build in 11m 14s on Mon, 1 Mar, 03:06 PM Test Summary: 75411 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1143

  3. Oli Bartsch uploaded patch set 2 03/02/21, 11:54

  4. TYPO3com voted on patch set 2 V -1 03/02/21, 12:05 Completed build in 10m 56s on Tue, 2 Mar, 12:05 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1155

  5. core-ci voted on patch set 2 V -1 03/02/21, 12:11 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1118

  6. Benni Mack commented on patch set 2 03/02/21, 12:42

    RemoteServer.php:617

    what if searchFields is empty / not set (PHP 8 strict types)
  7. Oli Bartsch uploaded patch set 3 03/02/21, 13:26

  8. Oli Bartsch commented on patch set 3 03/02/21, 13:28

    RemoteServer.php:617 Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 03/02/21, 13:39 Completed build in 13m 02s on Tue, 2 Mar, 01:39 PM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1156

  10. core-ci voted on patch set 3 V +1 03/02/21, 13:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1121

  11. Christian Kuhn updated the commit message in patch set 4 03/02/21, 17:43

  12. TYPO3com voted on patch set 4 V +1 03/02/21, 17:54 Completed build in 11m 17s on Tue, 2 Mar, 05:54 PM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1157

  13. core-ci voted on patch set 4 V -1 03/02/21, 17:57 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1126

  14. core-ci voted on patch set 4 V +1 03/02/21, 20:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1126

  15. Benni Mack voted on patch set 4 V +2 CR +2 03/02/21, 20:50

  16. Benni Mack merged patch set 5 03/02/21, 20:50