Review main Merged

68160[TASK] PHP 8 compatibility 1/x

Christian Kuhn CR +2 V +2 Normal +103 −78 updated 03/07/21, 21:42

Commit message

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 20

Review log 2041

Show 716 earlier messages
  1. Christian Kuhn uploaded patch set 1 03/01/21, 17:26

  2. TYPO3com voted on patch set 1 V +1 03/01/21, 17:33 Completed build in 06m 32s on Mon, 1 Mar, 05:33 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9785

  3. Christian Kuhn uploaded patch set 2 03/01/21, 17:36

  4. core-ci voted on patch set 1 V +1 03/01/21, 17:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1093

  5. TYPO3com voted on patch set 2 V +1 03/01/21, 17:42 Completed build in 06m 30s on Mon, 1 Mar, 05:42 PM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9786

  6. Christian Kuhn uploaded patch set 3 03/01/21, 19:22

  7. TYPO3com voted on patch set 3 V +1 03/01/21, 19:30 Completed build in 07m 19s on Mon, 1 Mar, 07:30 PM Test Summary: 32719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9790

  8. core-ci voted on patch set 2 V -1 03/01/21, 19:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1094

  9. Christian Kuhn uploaded patch set 4 03/01/21, 19:49

  10. TYPO3com voted on patch set 4 V +1 03/01/21, 19:59 Completed build in 09m 06s on Mon, 1 Mar, 07:58 PM Test Summary: 32719 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9792

  11. Christian Kuhn uploaded patch set 5 03/01/21, 20:17

  12. TYPO3com voted on patch set 5 V +1 03/01/21, 20:28 Completed build in 10m 36s on Mon, 1 Mar, 08:28 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9795

  13. Christian Kuhn uploaded patch set 6 03/01/21, 20:31

  14. TYPO3com voted on patch set 6 V +1 03/01/21, 20:38 Completed build in 07m 21s on Mon, 1 Mar, 08:38 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9797

  15. Christian Kuhn uploaded patch set 7 03/01/21, 20:52

  16. TYPO3com voted on patch set 7 V +1 03/01/21, 20:59 Completed build in 06m 53s on Mon, 1 Mar, 08:59 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9798

  1. core-ci voted on patch set 3 V -1 03/01/21, 21:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1098

  2. Christian Kuhn uploaded patch set 8 03/01/21, 21:38

  3. TYPO3com voted on patch set 8 V +1 03/01/21, 21:45 Completed build in 07m 06s on Mon, 1 Mar, 09:45 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9799

  4. core-ci voted on patch set 4 V -1 03/01/21, 21:51 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1101

  5. core-ci voted on patch set 5 V -1 03/01/21, 22:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1105

  6. Christian Kuhn uploaded patch set 9 03/01/21, 22:20

  7. TYPO3com voted on patch set 9 V +1 03/01/21, 22:27 Completed build in 06m 14s on Mon, 1 Mar, 10:27 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9800

  8. core-ci voted on patch set 6 V -1 03/01/21, 22:32 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1107

  9. core-ci voted on patch set 7 V -1 03/01/21, 22:54 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1108

  10. core-ci voted on patch set 8 V -1 03/01/21, 23:39 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1109

  11. core-ci voted on patch set 9 V -1 03/02/21, 00:22 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1110

  12. Christian Kuhn uploaded patch set 10 03/02/21, 18:40

  13. TYPO3com voted on patch set 10 V +1 03/02/21, 18:50 Completed build in 09m 51s on Tue, 2 Mar, 06:50 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9813

  14. Christian Kuhn uploaded patch set 11 03/02/21, 19:47

  15. Anja Leichsenring voted on patch set 11 V +1 CR +1 03/02/21, 19:50

  16. TYPO3com voted on patch set 11 V +1 03/02/21, 19:55 Completed build in 07m 59s on Tue, 2 Mar, 07:55 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9819

  17. core-ci voted on patch set 11 V +1 03/02/21, 19:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1134

  18. Richard Haeser voted on patch set 11 V +2 CR +2 03/02/21, 20:15

  19. Richard Haeser merged patch set 12 03/02/21, 20:15

  20. Oliver Hader commented on patch set 12 03/03/21, 07:22

    FileReference.php:83

    It looks like $this->name is not used at all? If that's correct, the line could be removed completely...
  21. Christian Kuhn commented on patch set 12 03/03/21, 09:11

    FileReference.php:83 Reply

    will check.
  22. Christian Kuhn commented on patch set 12 03/03/21, 11:11

    FileReference.php:83 Reply

    good catch ... i'll create a patch to drop this.
  23. Christian Kuhn commented on patch set 12 03/03/21, 11:16

  24. Frans Saris commented on patch set 12 03/06/21, 09:04

    hi all, first tnx for all your work and effort to the project and getting it ready for PHP8 I try to follow the core changes from time to time to see what's going on. And certainly changes to make it compatible with the next php version are interested. probably not only for me but also for all that work with TYPO3 and try to keep their codebase and extensions up-to-date. But I noticed that the commit messages of the 2 patches that landed in master the last days do not really tell what was done to make it compatible. The current commit message is more a label than a message about the change. This doesn't fully fit with the commit message rules from the contribution guide https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CommitMessage.html I would had expected something in the message/body that would tell about the needed changes. So others that see the mr know that we need to be more strict or something to write code that's compatible with PHP 8 when creating patch for the core. and know how to improve our coding style to keep up with the current TYPO3/PHP development 😊 maybe you could take that into consideration for next compatibility changes. nevertheless thank you for all your work!
  25. Christian Kuhn commented on patch set 12 03/07/21, 21:42

    Reply

    Hey Frans 😊 Thx 4 your note ... Nearly all of those PHP 8 issues are about array access ... which now throw warnings instead of notices. I'll mention that with next patch ;)