Review main Merged

68161[TASK] Use BE User uc API for storing EM settings

Benni Mack CR +2 V +2 Normal +12 −42 updated 03/02/21, 23:32

Commit message

The EM is not using the API for writing and reading the
UC, and can be massively simplified.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 1118

  1. Benni Mack uploaded patch set 1 03/01/21, 20:16

  2. TYPO3com voted on patch set 1 V -1 03/01/21, 20:17 Completed build in 01m 01s on Mon, 1 Mar, 08:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9794

  3. Benni Mack uploaded patch set 2 03/01/21, 20:26

  4. core-ci voted on patch set 1 V +1 03/01/21, 20:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1104

  5. TYPO3com voted on patch set 2 V +1 03/01/21, 20:33 Completed build in 07m 16s on Mon, 1 Mar, 08:33 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9796

  6. core-ci voted on patch set 2 V +1 03/01/21, 20:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1106

  7. Richard Haeser voted on patch set 2 CR +1 03/01/21, 21:06

  8. Wouter Wolters voted on patch set 2 CR +1 03/01/21, 21:38

  9. Christian Kuhn commented on patch set 2 CR -1 03/02/21, 17:35

    ListController.php:329

    Since this is a BE controller, there MUST be a BE_USER ... imho '?' can be dropped and the '?? null' below is not needed.
  10. Benni Mack commented on patch set 3 03/02/21, 21:18

    Published edit on patch set 2.
  11. TYPO3com voted on patch set 3 V -1 03/02/21, 21:26 Completed build in 07m 55s on Tue, 2 Mar, 09:26 PM Test Summary: 1 of 32971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9827

  12. core-ci voted on patch set 3 V +1 03/02/21, 21:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1143

  13. Christian Kuhn voted on patch set 3 CR +1 03/02/21, 23:12

  14. TYPO3com voted on patch set 3 V +1 03/02/21, 23:23 Completed build in 2h 13m 10s on Tue, 2 Mar, 11:23 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9827

  15. Oli Bartsch voted on patch set 3 V +1 CR +1 03/02/21, 23:29

  16. Oli Bartsch commented on patch set 3 03/02/21, 23:30

    ListController.php:329 Reply

    Done
  17. Richard Haeser voted on patch set 3 V +2 CR +2 03/02/21, 23:32

  18. Richard Haeser merged patch set 4 03/02/21, 23:32