Review main Merged

68164[BUGFIX] Skip MFA in switch-user mode

Oli Bartsch CR +2 V +2 Easy +16 −0 updated 03/02/21, 17:32

Commit message

In case of switching to a user, having MFA enabled,
with a user, having MFA disabled, the switching user
is required to pass the target users' MFA, because the
transformed session does not contain the `mfa` key.

Since it's obviously not possible to pass another users'
MFA, we need some exception for such scenario.

Therefore, the evaluateMfaRequirements() method
from AbstractUserAuthentication is overwritten by
BackendUserAuthentication to check if the current
session is a switch-user session. In this case,
MFA is skipped. Otherwise the parent method is
executed. Skipping MFA will be logged.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Markus Klein +1
    • Richard Haeser +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1016

  1. Oli Bartsch uploaded patch set 1 03/01/21, 23:45

  2. TYPO3com voted on patch set 1 V +1 03/01/21, 23:52 Completed build in 07m 20s on Mon, 1 Mar, 11:52 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9802

  3. core-ci voted on patch set 1 V +1 03/01/21, 23:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1112

  4. Oli Bartsch uploaded patch set 2 03/02/21, 09:50

  5. TYPO3com voted on patch set 2 V +1 03/02/21, 09:57 Completed build in 06m 59s on Tue, 2 Mar, 09:57 AM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9803

  6. core-ci voted on patch set 2 V +1 03/02/21, 10:01 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1116

  7. Markus Klein voted on patch set 2 CR +1 03/02/21, 10:05

  8. Benni Mack commented on patch set 2 CR -1 03/02/21, 10:56

    seems to be very complicated...
  9. Oli Bartsch uploaded patch set 3 03/02/21, 12:21

  10. TYPO3com voted on patch set 3 V +1 03/02/21, 12:28 Completed build in 06m 44s on Tue, 2 Mar, 12:28 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9805

  11. core-ci voted on patch set 3 V +1 03/02/21, 12:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1119

  12. Benni Mack voted on patch set 3 CR +1 03/02/21, 12:36

  13. Markus Klein voted on patch set 3 CR +1 03/02/21, 13:00

  14. Richard Haeser voted on patch set 3 V +1 CR +1 03/02/21, 14:46

  15. Georg Ringer voted on patch set 3 V +2 CR +2 03/02/21, 17:32

  16. Georg Ringer merged patch set 4 03/02/21, 17:32