Review main Merged

68165[BUGFIX] Fix TypeError in workspace module

Oli Bartsch CR +2 V +2 Easy +13 −9 updated 03/03/21, 18:46

Commit message

Accessing the workspace module while in live workspace
led to a JavaScript TypeError. This is fixed by proper type
checking.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 812

  1. Oli Bartsch uploaded patch set 1 03/02/21, 15:17

  2. TYPO3com voted on patch set 1 V +1 03/02/21, 15:24 Completed build in 06m 53s on Tue, 2 Mar, 03:24 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9807

  3. core-ci voted on patch set 1 V +1 03/02/21, 15:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1122

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 03/02/21, 17:58

  5. Oli Bartsch uploaded patch set 2 03/02/21, 23:34

  6. Oli Bartsch commented on patch set 2 03/02/21, 23:35

    Just resolved merge conflicts.
  7. TYPO3com voted on patch set 2 V +1 03/02/21, 23:42 Completed build in 07m 53s on Tue, 2 Mar, 11:42 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9829

  8. core-ci voted on patch set 2 V +1 03/02/21, 23:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1145

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 03/03/21, 10:40

  10. Jochen Roth voted on patch set 2 V +1 CR +1 03/03/21, 12:17

  11. Richard Haeser voted on patch set 2 V +2 CR +2 03/03/21, 18:46

  12. Richard Haeser merged patch set 3 03/03/21, 18:46