Review main Merged

68167[BUGFIX] Ensure Acceptance test operates on the correct form tab

Anja Leichsenring CR +2 V +2 Easy +10 −0 updated 03/02/21, 19:15

Commit message

Due to a interdependency between tests and a recent reordering, the
Input Range Test found itself on the wrong tab of the backend
input form.
The setup of the test now ensures the correct tab is active
before starting to fill out fields.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Richard Haeser +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Richard Haeser +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1319

  1. Anja Leichsenring uploaded patch set 1 03/02/21, 18:38

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 03/02/21, 18:41

  3. Anja Leichsenring uploaded patch set 2 03/02/21, 18:42

  4. Christian Kuhn voted on patch set 2 V +1 CR +1 03/02/21, 18:42

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 03/02/21, 18:43

  6. Richard Haeser voted on patch set 2 V +1 CR +1 03/02/21, 18:44

  7. TYPO3com voted on patch set 1 V -1 03/02/21, 18:46 Completed build in 07m 53s on Tue, 2 Mar, 06:46 PM Test Summary: 1 of 32969 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9812

  8. core-ci voted on patch set 1 V +1 03/02/21, 18:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1128

  9. TYPO3com voted on patch set 2 V -1 03/02/21, 18:52 Completed build in 10m 05s on Tue, 2 Mar, 06:52 PM Test Summary: 1 of 32969 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9814

  10. Anja Leichsenring uploaded patch set 3 03/02/21, 18:56

  11. core-ci voted on patch set 2 V +1 03/02/21, 18:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1130

  12. TYPO3com voted on patch set 3 V +1 03/02/21, 19:02 Completed build in 05m 54s on Tue, 2 Mar, 07:02 PM Test Summary: 32728 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9815

  13. Anja Leichsenring commented on patch set 3 03/02/21, 19:03

    due to the older chrome version run by bamboo, I also need to catch a second type of exception.
  14. core-ci voted on patch set 3 V +1 03/02/21, 19:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1131

  15. Richard Haeser voted on patch set 3 V +1 CR +1 03/02/21, 19:07

  16. Christian Kuhn voted on patch set 3 V +1 CR +1 03/02/21, 19:10

  17. Andreas Kienast voted on patch set 3 V +2 CR +2 03/02/21, 19:12

  18. Andreas Kienast merged patch set 4 03/02/21, 19:12

  19. Benjamin Franzke commented on patch set 3 03/02/21, 19:15

    ElementsBasicInputRangeCest.php:55 Unresolved

    Per changes/comments in https://review.typo3.org/c/Packages/TYPO3.CMS/+/68167/2..3 this only happens in older chrome, can it happen in younger as well? Would be great to add a comment, in case this can be removed once bamboo testing is a) updated to be on pair with gitlab-ci or is b) removed. It's not clear to me (without a comment), why a UnknownServerException can be silently ignored or why that means that the tab is active.