Review main Merged

68169[TASK] Update XLIFF version to 1.2

Georg Ringer CR +2 V +2 Hard +357 −453 updated 03/24/21, 19:14

Commit message

Update all XLIFF files to use version 1.2, which makes it possible to
use a validation schema.

Also drop the TYPO3-specific XLIFF file IDs (together with the reference
to the corresponding XML namespace) as those are not needed anymore,
but prevented XML validation.

Also drop checking the XLIFF file IDs from the CI jobs as this
does not make sense anymore now.

This change does not fix the discovered validation errors in the XLIFF
files. This will come later in a separate change.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 184

Show 164 more files

Review log 2639

Show 1014 earlier messages
  1. Georg Ringer uploaded patch set 1 03/02/21, 20:35

  2. TYPO3com voted on patch set 1 V -1 03/02/21, 20:42 Completed build in 07m 15s on Tue, 2 Mar, 08:42 PM Test Summary: 224 of 32971 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9821

  3. Georg Ringer uploaded patch set 2 03/02/21, 20:45

  4. core-ci voted on patch set 1 V -1 03/02/21, 20:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1137

  5. TYPO3com voted on patch set 2 V +1 03/02/21, 20:55 Completed build in 09m 56s on Tue, 2 Mar, 08:55 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9824

  6. core-ci voted on patch set 2 V +1 03/02/21, 20:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1140

  7. Georg Ringer commented on patch set 2 03/02/21, 22:32

    This change is ready for review.
  8. Benni Mack commented on patch set 2 CR -2 03/03/21, 08:47

    merge block due to some internal discussions with Georg.
  9. Oliver Klee voted on patch set 2 CR +1 03/13/21, 12:35

  10. Oliver Klee commented on patch set 2 03/13/21, 12:37

    With and without this change, we have this additional schema in most XLF files: xmlns:t3="http://typo3.org/schemas/xliff"; This is usually used for the id attribute: <file t3:id="1415814986" … However, the external location http://typo3.org/schemas/xliff is a 404. Does anyone know why, and what the ID attribute in the file node is used for? (This currently blocks validation with xmllint.)
  11. Georg Ringer commented on patch set 2 03/14/21, 20:55

    IMO we could drop that, has been added with https://review.typo3.org/c/Packages/TYPO3.CMS/+/34184/ but was a feature which was required for old translation server to make it possible to move files
  12. Tymoteusz Motylewski commented on patch set 2 03/15/21, 06:40

    Reply

  13. Oliver Klee commented on patch set 2 03/15/21, 14:43

    Reply Unresolved

    @Tymoteusz Thanks! Do you know whether we still need the ID? And if we still need it, do you know of a way to validate the files?
  14. Benni Mack voted on patch set 2 CR 0 03/16/21, 12:14

  1. Georg Ringer commented on patch set 2 03/16/21, 17:33

    we don't need the t3id for 11 + 10 and tbh we don't need to touch 9.5, so please remove 9.5
  2. Oliver Klee updated the commit message in patch set 3 03/16/21, 18:10

  3. Oliver Klee commented on patch set 3 CR +1 03/16/21, 18:11

    Reply

    Done.
  4. TYPO3com voted on patch set 3 V -1 03/16/21, 18:18 Completed build in 07m 42s on Tue, 16 Mar, 06:18 PM Test Summary: 32481 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10170

  5. core-ci voted on patch set 3 V -1 03/16/21, 18:21 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1610

  6. Oliver Klee commented on patch set 3 03/16/21, 20:06

    I honestly have no idea why the CI builds now are failing. I've only touched the commit message.
  7. Oliver Klee uploaded patch set 4 03/22/21, 11:51

  8. Oliver Klee commented on patch set 4 V +1 CR +1 03/22/21, 11:53

    Tested by using xmllint. (There are some validation errors, but at least xmlllint does not refuse to check the files.)
  9. Oliver Klee updated the commit message in patch set 5 03/22/21, 11:54

  10. Oliver Klee voted on patch set 5 V +1 CR +1 03/22/21, 11:54

  11. TYPO3com voted on patch set 4 V -1 03/22/21, 11:59 Completed build in 07m 17s on Mon, 22 Mar, 11:59 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10283

  12. TYPO3com voted on patch set 5 V -1 03/22/21, 12:02 Completed build in 07m 52s on Mon, 22 Mar, 12:02 PM Test Summary: 32906 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10284

  13. core-ci voted on patch set 4 V -1 03/22/21, 12:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1757

  14. core-ci voted on patch set 5 V -1 03/22/21, 12:10 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1758

  15. Oliver Klee uploaded patch set 6 03/22/21, 12:26

  16. TYPO3com voted on patch set 6 V -1 03/22/21, 12:34 Completed build in 07m 30s on Mon, 22 Mar, 12:34 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10285

  17. core-ci voted on patch set 6 V +1 03/22/21, 12:36 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1759

  18. Oliver Klee commented on patch set 6 03/22/21, 12:48

    https://bamboo.typo3.com/browse/CORE-GTC-10285 /srv/bamboo/temp/CORE-GTC-CDECC-10285-ScriptBuildTask-5325623016862536435.sh: line 10: ./Build/Scripts/xlfcheck.sh: No such file or directory Do we need to remove the call somewhere else (in addition to from the Core repository)?
  19. Andreas Kienast commented on patch set 6 03/23/21, 13:36

    FYI: I've removed the xlfcheck in Bamboo to get this patch green.
  20. TYPO3com voted on patch set 6 V +1 03/23/21, 13:42 Completed build in 06m 55s on Tue, 23 Mar, 01:42 PM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10312

  21. Georg Ringer voted on patch set 6 V +1 CR +1 03/23/21, 16:12

  22. Oliver Klee voted on patch set 6 V +1 CR +1 03/23/21, 21:51

  23. Benni Mack voted on patch set 6 V +1 CR +1 03/23/21, 21:52

  24. Georg Ringer voted on patch set 6 V +2 CR +2 03/24/21, 19:14

  25. Georg Ringer merged patch set 7 03/24/21, 19:14