Review main Merged

68170[BUGFIX] Inject Logger into LanguagePackService

Martin Kutschker CR +2 V +2 Easy +16 −8 updated 03/03/21, 09:15

Commit message

The EXT:install ServiceProvider introduced in #89892 didn't respect
that LanguagePackService implements LoggerAwareInterface. That means
the logger variable was null and usages of the logger resulted in
exceptions.

Refactor the class to require the logger instance to always be
injected via constructor injection, to prevent this from happening
again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • Oliver Wand +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 713

  1. Martin Kutschker uploaded patch set 1 03/02/21, 20:38

  2. TYPO3com voted on patch set 1 V -1 03/02/21, 20:38 Completed build in 13s on Tue, 2 Mar, 08:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9822

  3. core-ci voted on patch set 1 V -1 03/02/21, 20:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1138

  4. Martin Kutschker uploaded patch set 2 03/02/21, 20:42

  5. TYPO3com voted on patch set 2 V +1 03/02/21, 20:51 Completed build in 08m 19s on Tue, 2 Mar, 08:51 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9823

  6. core-ci voted on patch set 2 V +1 03/02/21, 20:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1139

  7. Benjamin Franzke uploaded patch set 3 03/02/21, 21:01

  8. Benjamin Franzke commented on patch set 3 03/02/21, 21:01

    ServiceProvider.php:153

    Although I initally suggested `self::new`, i'd rather like to keep `new` here, as I don't want broken xclass configuration in LocalConfiguration to break the installtool. Using `new` (avoiding possibly global XCLASS settings) is actually a hardening, therefore I'd now opt to keep it. Fix in patchset 3.
  9. TYPO3com voted on patch set 3 V +1 03/02/21, 21:11 Completed build in 09m 38s on Tue, 2 Mar, 09:11 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9826

  10. core-ci voted on patch set 3 V +1 03/02/21, 21:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1142

  11. Oliver Wand voted on patch set 3 CR +1 03/03/21, 07:47

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 03/03/21, 09:10

  13. Christian Kuhn merged patch set 4 03/03/21, 09:15