Review 10.4 Merged

68172[BUGFIX] Inject Logger into LanguagePackService

Christian Kuhn CR +2 V +2 Easy +17 −8 updated 03/03/21, 09:43

Commit message

The EXT:install ServiceProvider introduced in #89892 didn't respect
that LanguagePackService implements LoggerAwareInterface. That means
the logger variable was null and usages of the logger resulted in
exceptions.

Refactor the class to require the logger instance to always be
injected via constructor injection, to prevent this from happening
again.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
  • Verified V +2 Done
    • Christian Kuhn +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 2

Review log 35

  1. Christian Kuhn uploaded patch set 1 03/03/21, 09:20

  2. TYPO3com voted on patch set 1 V +1 03/03/21, 09:28 Completed build in 08m 05s on Wed, 3 Mar, 09:28 AM Test Summary: 75426 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1161

  3. core-ci voted on patch set 1 V +1 03/03/21, 09:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1149

  4. Christian Kuhn voted on patch set 1 V +2 CR +2 03/03/21, 09:42

  5. Christian Kuhn merged patch set 2 03/03/21, 09:43