Review main Merged

68173[DOCS] Update outdated information about FlashMessagesViewHelper caching

Daniel Siepmann CR +2 V +2 Easy +6 −3 updated 03/03/21, 10:34

Commit message

The ViewHelper does not clear cache since 7.3.0 change:
https://review.typo3.org/c/Packages/TYPO3.CMS/+/34818
Still the documentation states it will clear cache.

Instead users need to take care to properly clear cache.
The background:

FlashMessages often tend to be part of a process and already work with
proper cHash and URLs. Unique URLs often lead to unique output of
FlashMessages.
Under some circumstances flash messages might be created before
redirecting to a generic URL.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Mathias Brodala +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Mathias Brodala +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 711

  1. Daniel Siepmann uploaded patch set 1 03/03/21, 10:13

  2. Mathias Brodala commented on patch set 1 03/03/21, 10:17

    Small wording suggestion.

    FlashMessagesViewHelper.php:121

    > In case of conditional flash message rendering, caching must be disabled (e.g. for a controller action). Custom caching using the Caching Framework can be used in this case.
  3. Daniel Siepmann uploaded patch set 2 03/03/21, 10:19

  4. TYPO3com voted on patch set 1 V +1 03/03/21, 10:20 Completed build in 06m 46s on Wed, 3 Mar, 10:20 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9830

  5. Daniel Siepmann commented on patch set 2 03/03/21, 10:22

    FlashMessagesViewHelper.php:121 Reply

    Done
  6. core-ci voted on patch set 1 V +1 03/03/21, 10:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1150

  7. Mathias Brodala commented on patch set 2 V +1 CR +1 03/03/21, 10:26

    Verified by knowledge. ;-)
  8. TYPO3com voted on patch set 2 V +1 03/03/21, 10:26 Completed build in 06m 47s on Wed, 3 Mar, 10:26 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9831

  9. core-ci voted on patch set 2 V +1 03/03/21, 10:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1151

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 03/03/21, 10:34

  11. Christian Kuhn merged patch set 3 03/03/21, 10:34