68175[TASK] PHP 8 compatibility 2/x
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Richard Haeser +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+6 −5
- typo3/sysext/core/Classes/Database/RelationHandler.php+3 −1
- typo3/sysext/core/Classes/DataHandling/DataHandler.php4+80 −66
- typo3/sysext/core/Classes/DataHandling/ItemProcessingService.php+2 −2
- typo3/sysext/core/Classes/Utility/RootlineUtility.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentContentObject.php+8 −3
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+20 −19
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+90 −0
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php+1 −1
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+1 −1
Review log 1020
-
Christian Kuhn uploaded patch set 1 03/03/21, 12:45
-
TYPO3com voted on patch set 1 V -1 03/03/21, 12:45 Completed build in 21s on Wed, 3 Mar, 12:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9833
-
core-ci voted on patch set 1 V -1 03/03/21, 12:46 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1154
-
Christian Kuhn uploaded patch set 2 03/03/21, 14:12
-
TYPO3com voted on patch set 2 V +1 03/03/21, 14:18 Completed build in 06m 16s on Wed, 3 Mar, 02:18 PM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9835
-
core-ci voted on patch set 2 V -1 03/03/21, 16:13 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1156
-
Christian Kuhn uploaded patch set 3 03/03/21, 21:23
-
TYPO3com voted on patch set 3 V -1 03/03/21, 21:31 Completed build in 08m 12s on Wed, 3 Mar, 09:31 PM Test Summary: 336 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9836
-
Christian Kuhn uploaded patch set 4 03/03/21, 21:47
-
TYPO3com voted on patch set 4 V +1 03/03/21, 21:55 Completed build in 07m 30s on Wed, 3 Mar, 09:55 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9837
-
Christian Kuhn uploaded patch set 5 03/03/21, 21:59
-
TYPO3com voted on patch set 5 V +1 03/03/21, 22:06 Completed build in 07m 14s on Wed, 3 Mar, 10:06 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9838
-
core-ci voted on patch set 5 V +1 03/03/21, 22:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1162
-
core-ci voted on patch set 3 V -1 03/03/21, 23:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1160
-
core-ci voted on patch set 4 V -1 03/03/21, 23:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1161
-
Anja Leichsenring commented on patch set 5 03/04/21, 06:19
-
Richard Haeser commented on patch set 5 V +1 CR +1 03/04/21, 08:28
DataHandler.php:8041ReplyAFAIK it is ok to return false when the key 'foreign_table' is not set as well. -
Christian Kuhn commented on patch set 5 03/04/21, 09:12
DataHandler.php:8041Replyshould be ok in this case: foreign_table is a required key with type=inline, and it is a string. returning false here if 'type' or 'foreign_table' are empty should be ok. -
Anja Leichsenring commented on patch set 5 V +2 CR +2 03/04/21, 09:14
DataHandler.php:8041ReplyAck -
Anja Leichsenring merged patch set 6 03/04/21, 09:14
DataHandler.php:8041