Review 9.5 Abandoned

68178[BUGFIX] Do not update session when there is no session ID

Christian Weiske CR 0 V 0 Easy +8 −5 updated 10/03/21, 14:53

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 710

  1. Christian Weiske uploaded patch set 1 03/03/21, 16:42

  2. Markus Klein commented on patch set 1 CR -1 03/03/21, 16:48

    If this is present in all newer versions too, please push the patch accordingly to master and name the releases in the message as well.
  3. TYPO3com voted on patch set 1 V +1 03/03/21, 16:51 Completed build in 09m 01s on Wed, 3 Mar, 04:51 PM Test Summary: 75298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1014

  4. core-ci voted on patch set 1 V +1 03/03/21, 16:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1157

  5. Markus Klein commented on patch set 1 03/09/21, 17:17

    Can you provide an easy way to reproduce the problem please? I want/need to test this on v11 as well. The code is already completely different there though.
  6. TYPO3com voted on patch set 1 V -1 03/16/21, 10:03 Completed build in 12m 08s on Tue, 16 Mar, 10:03 AM Test Summary: 1 of 76396 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1034

  7. Christian Weiske commented on patch set 1 03/16/21, 10:07

    Unresolved

    I will try to fix this in TYPO3 v10 myself, probably this or next week. Steps to reproduce: You need to run a CLI script that queues and renders flash messages. Using `\TYPO3\CMS\Core\Messaging\FlashMessageQueue::getAllMessagesAndFlush()` triggers the bug.
  8. Christian Weiske commented on patch set 1 03/18/21, 14:22

    The patch here applies to v10 without problems. In TYPO3 v11, it does not work anymore as you said - too many things changed. I do not plan to test this on v11.
  9. Benni Mack abandoned the change 10/03/21, 14:53

    This change is abandoned as there is no upcoming free-of-charge 9.5 release anymore.
  10. Benni Mack commented on patch set 1 10/03/21, 14:53

    Feel free to push to the master branch first.