68181[DOCS] Fix broken cross reference to changelog entry
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 1
Review log 813
-
Daniel Siepmann uploaded patch set 1 03/04/21, 07:54
-
core-ci voted on patch set 1 V +1 03/04/21, 08:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1166
-
Oli Bartsch commented on patch set 1 03/04/21, 08:27
Since this is a docs change targeting a 9.X changelog, backporting to 9.5 seems reasonable. What do you think?Deprecation-86068-OldConditionSyntax.rst:15What about using the absolute URL here? Or even better using a reference, which seems to be the most common method lately. -
Daniel Siepmann uploaded patch set 2 03/04/21, 08:27
-
Daniel Siepmann updated the commit message in patch set 3 03/04/21, 08:28
-
Daniel Siepmann commented on patch set 3 03/04/21, 08:31
Reply
Done, wasn't sure as 9.5 is in security mode only, and I didn't want to create extra work. But that back port should be easy.Deprecation-86068-OldConditionSyntax.rst:15ReplyI've switched to :doc:, see: https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#role-doc -
TYPO3com voted on patch set 2 V +1 03/04/21, 08:35 Completed build in 07m 05s on Thu, 4 Mar, 08:35 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9839
-
Oli Bartsch voted on patch set 3 V +1 CR +1 03/04/21, 08:36
-
core-ci voted on patch set 2 V +1 03/04/21, 08:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1167
-
TYPO3com voted on patch set 3 V +1 03/04/21, 08:38 Completed build in 10m 05s on Thu, 4 Mar, 08:38 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9840
-
core-ci voted on patch set 3 V +1 03/04/21, 08:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1168
-
Christian Kuhn voted on patch set 3 V +2 CR +2 03/04/21, 09:20
-
Christian Kuhn merged patch set 4 03/04/21, 09:21