Review main Merged

68181[DOCS] Fix broken cross reference to changelog entry

Daniel Siepmann CR +2 V +2 Easy +1 −1 updated 03/04/21, 09:21

Commit message

The reference to 85829 was broken.
It linked to 9.5 while the actual change was made in 9.4.
Therefore the link is adjusted to link to the actual existing file.

We use the :doc: syntax to allow sphinx to properly build the URL from
relative file path.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 813

  1. Daniel Siepmann uploaded patch set 1 03/04/21, 07:54

  2. core-ci voted on patch set 1 V +1 03/04/21, 08:04 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1166

  3. Oli Bartsch commented on patch set 1 03/04/21, 08:27

    Since this is a docs change targeting a 9.X changelog, backporting to 9.5 seems reasonable. What do you think?

    Deprecation-86068-OldConditionSyntax.rst:15

    What about using the absolute URL here? Or even better using a reference, which seems to be the most common method lately.
  4. Daniel Siepmann uploaded patch set 2 03/04/21, 08:27

  5. Daniel Siepmann updated the commit message in patch set 3 03/04/21, 08:28

  6. Daniel Siepmann commented on patch set 3 03/04/21, 08:31

    Reply

    Done, wasn't sure as 9.5 is in security mode only, and I didn't want to create extra work. But that back port should be easy.

    Deprecation-86068-OldConditionSyntax.rst:15 Reply

  7. TYPO3com voted on patch set 2 V +1 03/04/21, 08:35 Completed build in 07m 05s on Thu, 4 Mar, 08:35 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9839

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 03/04/21, 08:36

  9. core-ci voted on patch set 2 V +1 03/04/21, 08:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1167

  10. TYPO3com voted on patch set 3 V +1 03/04/21, 08:38 Completed build in 10m 05s on Thu, 4 Mar, 08:38 AM Test Summary: 32730 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9840

  11. core-ci voted on patch set 3 V +1 03/04/21, 08:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1168

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 03/04/21, 09:20

  13. Christian Kuhn merged patch set 4 03/04/21, 09:21