Review main Merged

68182[BUGFIX] Use Live Page ID in workspace routing

Benni Mack CR +2 V +2 Easy +6 −3 updated 03/09/21, 13:27

Commit message

When in a workspace, the slug of a workspace'd
page record is properly resolved (good!), but
the versioned ID of the page is used within
the PageArguments.

This is in turn lets TSFE think that the "Page ID"
is the versioned ID, which is wrong (similarly to
the localized page ID / translated page ID), which
always need to be the live Page ID in order to
properly handle records on the page ("pid=live/default ID of the page")

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 713

  1. Benni Mack uploaded patch set 1 03/04/21, 12:52

  2. TYPO3com voted on patch set 1 V -1 03/04/21, 12:59 Completed build in 06m 26s on Thu, 4 Mar, 12:59 PM Test Summary: 4 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9842

  3. core-ci voted on patch set 1 V -1 03/04/21, 13:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1172

  4. Benni Mack uploaded patch set 2 03/04/21, 15:08

  5. TYPO3com voted on patch set 2 V +1 03/04/21, 15:15 Completed build in 06m 25s on Thu, 4 Mar, 03:15 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9844

  6. core-ci voted on patch set 2 V +1 03/04/21, 15:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1174

  7. Benni Mack updated the commit message in patch set 3 03/04/21, 16:24

  8. TYPO3com voted on patch set 3 V +1 03/04/21, 16:30 Completed build in 06m 23s on Thu, 4 Mar, 04:30 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9845

  9. core-ci voted on patch set 3 V +1 03/04/21, 16:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1175

  10. Christian Kuhn voted on patch set 3 V +1 CR +1 03/08/21, 17:11

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 03/09/21, 13:01

  12. Benni Mack voted on patch set 3 V +2 CR +2 03/09/21, 13:27

  13. Benni Mack merged patch set 4 03/09/21, 13:27