Review main Merged

68185[BUGFIX] Show records in ws preview if live is hidden

Christian Kuhn CR +2 V +2 Normal +78 −0 updated 03/06/21, 11:20

Commit message

Scenario: A translated content element is hidden in
live, a workspace overlay is not hidden. In workspace
preview, the element should be shown - since it is not
hidden in workspace. This is not the case.
The patch fixes this: The 'base' db call for content
elements ignores hidden & time based restrictions and
elements are sorted out by versionOl() instead, if a
workspace preview is requested.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Sebastian Michaelsen +1
  • Verified V +2 Done
    • Benni Mack +2
    • Sebastian Michaelsen +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 715

  1. Christian Kuhn uploaded patch set 1 03/04/21, 18:46

  2. TYPO3com voted on patch set 1 V +1 03/04/21, 18:53 Completed build in 06m 25s on Thu, 4 Mar, 06:53 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9848

  3. core-ci voted on patch set 1 V +1 03/04/21, 18:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1178

  4. Christian Kuhn uploaded patch set 2 03/04/21, 19:03

  5. core-ci voted on patch set 2 V +1 03/04/21, 19:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1180

  6. TYPO3com voted on patch set 2 V -1 03/04/21, 19:18 Completed build in 15m 09s on Thu, 4 Mar, 07:18 PM Test Summary: 31930 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9850

  7. Christian Kuhn uploaded patch set 3 03/04/21, 20:24

  8. TYPO3com voted on patch set 3 V -1 03/04/21, 20:32 Completed build in 07m 50s on Thu, 4 Mar, 08:32 PM Test Summary: 3 of 32986 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9856

  9. Christian Kuhn uploaded patch set 4 03/04/21, 20:35

  10. core-ci voted on patch set 3 V -1 03/04/21, 20:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1186

  11. TYPO3com voted on patch set 4 V +1 03/04/21, 20:43 Completed build in 07m 32s on Thu, 4 Mar, 08:43 PM Test Summary: 32743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9857

  12. core-ci voted on patch set 4 V +1 03/04/21, 20:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1187

  13. Sebastian Michaelsen voted on patch set 4 V +1 CR +1 03/06/21, 11:04

  14. Benni Mack voted on patch set 4 V +2 CR +2 03/06/21, 11:20

  15. Benni Mack merged patch set 5 03/06/21, 11:20