Review main Merged

68187[BUGFIX] Hide radio button in upgrade wizard's buttons

Georg Ringer CR +2 V +2 Easy +6 −3 updated 03/17/21, 10:45

Commit message

Since the upgrade of bootstrap, the radio button inside the
upgrade wizards' buttons are shown.

The change utilizes btn-check functionality from Bootstrap 5

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 915

  1. Georg Ringer uploaded patch set 1 03/04/21, 19:38

  2. Georg Ringer commented on patch set 1 03/04/21, 19:39

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/04/21, 19:45 Completed build in 06m 50s on Thu, 4 Mar, 07:45 PM Test Summary: 1 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9851

  4. core-ci voted on patch set 1 V -1 03/04/21, 19:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1181

  5. Richard Haeser uploaded patch set 2 03/04/21, 19:51

  6. Richard Haeser voted on patch set 2 V +1 CR +1 03/04/21, 19:54

  7. TYPO3com voted on patch set 2 V +1 03/04/21, 19:59 Completed build in 07m 11s on Thu, 4 Mar, 07:58 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9852

  8. core-ci voted on patch set 2 V +1 03/04/21, 20:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1182

  9. Oli Bartsch commented on patch set 2 V -1 03/04/21, 20:50

    The buttons still don't change their active state. By hiding the radio, the user has no clue, which button (option) is activated when clicking "Perform update".
  10. Benni Mack uploaded patch set 3 03/17/21, 07:40

  11. TYPO3com voted on patch set 3 V +1 03/17/21, 07:48 Completed build in 07m 44s on Wed, 17 Mar, 07:48 AM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10177

  12. core-ci voted on patch set 3 V +1 03/17/21, 07:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1620

  13. Oli Bartsch voted on patch set 3 V +1 CR +1 03/17/21, 10:42

  14. Richard Haeser voted on patch set 3 V +2 CR +2 03/17/21, 10:45

  15. Richard Haeser merged patch set 4 03/17/21, 10:45