Review main Merged

68188[TASK] Do not use SiteFinder to fetch Site in Frontend

Benni Mack CR +2 V +2 Normal +26 −73 updated 03/08/21, 20:46

Commit message

TSFE now always contains the Site object so it is not necessary to
use the SiteFinder based on the ID to fetch the correct Site anymore,
but use TSFE->getSite() directly.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1117

  1. Benni Mack uploaded patch set 1 03/04/21, 19:52

  2. Markus Klein updated the commit message in patch set 2 03/04/21, 19:58

  3. Markus Klein voted on patch set 2 V +1 CR +1 03/04/21, 20:01

  4. TYPO3com voted on patch set 1 V -1 03/04/21, 20:02 Completed build in 09m 57s on Thu, 4 Mar, 08:02 PM Test Summary: 2 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9853

  5. core-ci voted on patch set 1 V -1 03/04/21, 20:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1183

  6. TYPO3com voted on patch set 2 V -1 03/04/21, 20:06 Completed build in 08m 10s on Thu, 4 Mar, 08:06 PM Test Summary: 2 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9854

  7. core-ci voted on patch set 2 V -1 03/04/21, 20:09 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1184

  8. Josef Glatz commented on patch set 2 03/05/21, 05:25

    Why not adding this also for 10.4?
  9. Josef Glatz voted on patch set 2 V +1 CR +1 03/05/21, 05:32

  10. Josef Glatz voted on patch set 2 V 0 03/05/21, 05:32

  11. Benni Mack uploaded patch set 3 03/05/21, 14:19

  12. TYPO3com voted on patch set 3 V +1 03/05/21, 14:25 Completed build in 06m 18s on Fri, 5 Mar, 02:25 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9869

  13. Benni Mack commented on patch set 3 03/05/21, 14:27

    Reply Unresolved

    no real bugfix...
  14. core-ci voted on patch set 3 V +1 03/05/21, 14:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1202

  15. Georg Ringer voted on patch set 3 V +1 CR +1 03/08/21, 20:29

  16. Richard Haeser voted on patch set 3 V +2 CR +2 03/08/21, 20:46

  17. Richard Haeser merged patch set 4 03/08/21, 20:46