68188[TASK] Do not use SiteFinder to fetch Site in Frontend
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Georg Ringer +1
-
Verified V +2 Done
- Richard Haeser +2
- Georg Ringer +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php+4 −12
- typo3/sysext/frontend/Classes/DataProcessing/LanguageMenuProcessor.php+4 −12
- typo3/sysext/frontend/Classes/DataProcessing/MenuProcessor.php+1 −9
- typo3/sysext/frontend/Classes/DataProcessing/SiteProcessor.php+12 −27
- typo3/sysext/frontend/Tests/Unit/DataProcessing/SiteProcessorTest.php+5 −13
Review log 1117
-
Benni Mack uploaded patch set 1 03/04/21, 19:52
-
Markus Klein updated the commit message in patch set 2 03/04/21, 19:58
-
Markus Klein voted on patch set 2 V +1 CR +1 03/04/21, 20:01
-
TYPO3com voted on patch set 1 V -1 03/04/21, 20:02 Completed build in 09m 57s on Thu, 4 Mar, 08:02 PM Test Summary: 2 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9853
-
core-ci voted on patch set 1 V -1 03/04/21, 20:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1183
-
TYPO3com voted on patch set 2 V -1 03/04/21, 20:06 Completed build in 08m 10s on Thu, 4 Mar, 08:06 PM Test Summary: 2 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9854
-
core-ci voted on patch set 2 V -1 03/04/21, 20:09 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1184
-
Josef Glatz commented on patch set 2 03/05/21, 05:25
Why not adding this also for 10.4? -
Josef Glatz voted on patch set 2 V +1 CR +1 03/05/21, 05:32
-
Josef Glatz voted on patch set 2 V 0 03/05/21, 05:32
-
Benni Mack uploaded patch set 3 03/05/21, 14:19
-
TYPO3com voted on patch set 3 V +1 03/05/21, 14:25 Completed build in 06m 18s on Fri, 5 Mar, 02:25 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9869
-
Benni Mack commented on patch set 3 03/05/21, 14:27
Reply Unresolved
no real bugfix... -
core-ci voted on patch set 3 V +1 03/05/21, 14:29 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1202
-
Georg Ringer voted on patch set 3 V +1 CR +1 03/08/21, 20:29
-
Richard Haeser voted on patch set 3 V +2 CR +2 03/08/21, 20:46
-
Richard Haeser merged patch set 4 03/08/21, 20:46