68192[FEATURE] Use database field be_users.lang for UI language
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 21
- typo3/sysext/backend/Classes/Authentication/PasswordReset.php+2 −3
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php1+17 −0
- typo3/sysext/backend/Classes/Security/EmailLoginNotification.php1+1 −1
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php1+3 −2
- typo3/sysext/core/Classes/Localization/LanguageService.php+3 −3
- typo3/sysext/core/Classes/Localization/TcaSystemLanguageCollector.phpnew+59 −0
- typo3/sysext/core/Configuration/TCA/Overrides/be_users.phpdeleted+0 −13
- typo3/sysext/core/Configuration/TCA/be_users.php+7 −1
- typo3/sysext/core/Configuration/Services.yaml+3 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-93663-BackendUsersPreferredUILanguageStoredAsDBField.rstnew+55 −0
- typo3/sysext/core/Resources/Private/Language/locallang_tca.xlf+10 −1
- typo3/sysext/core/ext_tables.sql+1 −1
- typo3/sysext/extbase/Classes/Utility/LocalizationUtility.php+2 −2
- typo3/sysext/extbase/Tests/Unit/Utility/LocalizationUtilityTest.php+1 −1
- typo3/sysext/form/Classes/Service/TranslationService.php+2 −2
- typo3/sysext/install/Classes/Updates/BackendUserLanguageMigration.phpnew+111 −0
- typo3/sysext/install/ext_localconf.php+2 −0
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php+2 −1
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php+36 −36
- typo3/sysext/setup/ext_tables.php1+2 −2
Review log 1330
Show 35 earlier messages
-
Benni Mack uploaded patch set 1 03/05/21, 10:59
-
TYPO3com voted on patch set 1 V -1 03/05/21, 11:05 Completed build in 06m 02s on Fri, 5 Mar, 11:05 AM Test Summary: 3561 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9861
-
core-ci voted on patch set 1 V -1 03/05/21, 11:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1194
-
Benni Mack uploaded patch set 2 03/05/21, 12:48
-
Benni Mack uploaded patch set 3 03/05/21, 12:52
-
TYPO3com voted on patch set 2 V -1 03/05/21, 12:56 Completed build in 08m 19s on Fri, 5 Mar, 12:56 PM Test Summary: 3778 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9864
-
TYPO3com voted on patch set 3 V +1 03/05/21, 13:04 Completed build in 11m 57s on Fri, 5 Mar, 01:04 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9866
-
core-ci voted on patch set 2 V -1 03/05/21, 13:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1197
-
core-ci voted on patch set 3 V +1 03/05/21, 13:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1199
-
Benni Mack uploaded patch set 4 03/05/21, 14:08
-
TYPO3com voted on patch set 4 V +1 03/05/21, 14:14 Completed build in 06m 45s on Fri, 5 Mar, 02:14 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9868
-
core-ci voted on patch set 4 V +1 03/05/21, 14:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1201
-
Benni Mack uploaded patch set 5 03/05/21, 15:57
-
TYPO3com voted on patch set 5 V +1 03/05/21, 16:04 Completed build in 06m 49s on Fri, 5 Mar, 04:04 PM Test Summary: 32741 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9871
-
core-ci voted on patch set 5 V +1 03/05/21, 16:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1204
-
Markus Klein updated the commit message in patch set 6 03/05/21, 21:10
-
TYPO3com voted on patch set 6 V +1 03/05/21, 21:16 Completed build in 06m 45s on Fri, 5 Mar, 09:16 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9872
-
core-ci voted on patch set 6 V +1 03/05/21, 21:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1205
-
Christian Kuhn commented on patch set 6 CR -1 03/08/21, 11:16
-1 for now. oli is working on it, too.EditDocumentController.php:567Unresolvedisset() could be dropped here since this is covered by !empty(), and empty does not raise errors if array does not exist.EmailLoginNotification.php:117Unresolved!empty() is sufficient, isset() not needed.BackendUserAuthentication.php:2281Unresolvedplease tag with @deprecated, so we find this in v12 later.ext_tables.php:70Unresolvedobsolete. -
Oli Bartsch uploaded patch set 7 03/08/21, 11:24
-
TYPO3com voted on patch set 7 V -1 03/08/21, 11:31 Completed build in 06m 28s on Mon, 8 Mar, 11:31 AM Test Summary: 18 of 32986 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9921
-
core-ci voted on patch set 7 V -1 03/08/21, 11:34 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1266
-
Oli Bartsch uploaded patch set 8 03/08/21, 11:39
-
TYPO3com voted on patch set 8 V -1 03/08/21, 11:45 Completed build in 06m 14s on Mon, 8 Mar, 11:45 AM Test Summary: 1 of 32986 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9922
-
core-ci voted on patch set 8 V +1 03/08/21, 11:54 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1267
-
TYPO3com voted on patch set 8 V +1 03/08/21, 11:56 Completed build in 23m 11s on Mon, 8 Mar, 11:56 AM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9922
-
Oli Bartsch voted on patch set 8 V +1 CR +1 03/08/21, 12:00
-
Christian Kuhn voted on patch set 8 V +1 CR +1 03/08/21, 12:55
-
Christian Kuhn voted on patch set 8 V +2 CR +2 03/08/21, 13:14
-
Christian Kuhn merged patch set 9 03/08/21, 13:14