68193[TASK] Fix phpstan checkFunctionArgumentTypes errors in MFA
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/backend/Classes/Controller/AbstractMfaController.php+0 −9
- typo3/sysext/backend/Classes/Controller/MfaAjaxController.php1+50 −39
- typo3/sysext/backend/Classes/Controller/MfaConfigurationController.php+88 −118
- typo3/sysext/backend/Classes/Controller/MfaController.php+62 −85
- typo3/sysext/backend/Classes/Form/Element/MfaInfoElement.php+2 −2
Review log 1119
-
Daniel Goerz uploaded patch set 1 03/05/21, 12:30
-
TYPO3com voted on patch set 1 V -1 03/05/21, 12:30 Completed build in 10s on Fri, 5 Mar, 12:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9862
-
Daniel Goerz uploaded patch set 2 03/05/21, 12:31
-
Daniel Goerz wrote 03/05/21, 12:31
Topic set to phpstan -
core-ci voted on patch set 1 V -1 03/05/21, 12:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1195
-
TYPO3com voted on patch set 2 V +1 03/05/21, 12:38 Completed build in 07m 14s on Fri, 5 Mar, 12:38 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9863
-
core-ci voted on patch set 2 V +1 03/05/21, 12:41 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1196
-
Benni Mack commented on patch set 2 03/05/21, 12:45
looks goodMfaAjaxController.php:81UnresolvedAbstractUserAuthentication -
Daniel Goerz uploaded patch set 3 03/05/21, 12:50
-
TYPO3com voted on patch set 3 V +1 03/05/21, 13:00 Completed build in 09m 28s on Fri, 5 Mar, 01:00 PM Test Summary: 32742 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9865
-
core-ci voted on patch set 3 V +1 03/05/21, 13:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1198
-
Daniel Goerz commented on patch set 3 03/05/21, 13:42
This patch is needed before we can finish https://review.typo3.org/c/Packages/TYPO3.CMS/+/68193 -
Oli Bartsch commented on patch set 3 CR -1 03/05/21, 18:23
Thanks for the patch. I will have a detailed look into it, therefore -1 for now. -
Oli Bartsch uploaded patch set 4 03/08/21, 09:18
-
TYPO3com voted on patch set 4 V +1 03/08/21, 09:25 Completed build in 06m 48s on Mon, 8 Mar, 09:25 AM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9916
-
Oli Bartsch voted on patch set 4 V +1 CR +1 03/08/21, 09:27
-
Benni Mack voted on patch set 4 V +2 CR +2 03/08/21, 09:27
-
core-ci voted on patch set 4 V +1 03/08/21, 09:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1261
-
Benni Mack merged patch set 5 03/08/21, 09:38