Review main Merged

68196[BUGFIX] Do not log failed HMAC validation from forms

Torben Hansen CR +2 V +2 Easy +8 −2 updated 04/06/21, 16:28

Commit message

When a HMAC of a submitted form is invalid, TYPO3 throws
a BadRequestException which is logged to sys_log and logfiles.
Those invalid HMAC validation errors occur when the values
of the hidden fields tx_extension[__trustedProperties]
(extbase) or tx_form_formframework[form-id][__state] (ext:form)
are manipulated.

Since a TYPO3 site owner has no reasonable possibility to
prevent tampered form submissions and in order to keep logs
clean from errors due to illegal requests, the exceptions
are now not logged any more.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Oli Bartsch +1
    • Richard Haeser +1
    • Mathias Brodala +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Josef Glatz +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 1

Review log 1927

Show 12 earlier messages
  1. Torben Hansen uploaded patch set 1 03/06/21, 07:01

  2. TYPO3com voted on patch set 1 V -1 03/06/21, 07:08 Completed build in 06m 45s on Sat, 6 Mar, 07:08 AM Test Summary: 1 of 32983 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9873

  1. core-ci voted on patch set 1 V +1 03/06/21, 07:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1209

  2. Oliver Klee commented on patch set 2 03/06/21, 21:17

    Published edit on patch set 1.
  3. TYPO3com voted on patch set 2 V +1 03/06/21, 21:24 Completed build in 07m 18s on Sat, 6 Mar, 09:24 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9887

  4. core-ci voted on patch set 2 V +1 03/06/21, 21:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1226

  5. Richard Haeser voted on patch set 2 CR +1 03/08/21, 10:04

  6. Georg Ringer voted on patch set 2 V +1 CR +1 03/08/21, 13:15

  7. Georg Ringer commented on patch set 2 03/08/21, 13:16

    no 11.1 for that
  8. Torben Hansen updated the commit message in patch set 3 03/08/21, 13:22

  9. Torben Hansen commented on patch set 3 03/08/21, 13:22

    Reply

    Done
  10. TYPO3com voted on patch set 3 V +1 03/08/21, 13:29 Completed build in 07m 11s on Mon, 8 Mar, 01:29 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9926

  11. core-ci voted on patch set 3 V +1 03/08/21, 13:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1270

  12. Josef Glatz voted on patch set 3 CR +1 03/08/21, 13:36

  13. Josef Glatz voted on patch set 3 V +1 03/08/21, 13:37

  14. Oli Bartsch commented on patch set 3 03/08/21, 14:21

    AbstractExceptionHandler.php:42

    I assume, this set of exception codes should not be changed? In this case I suggest using a private const instead.
  15. Torben Hansen uploaded patch set 4 03/08/21, 17:38

  16. Torben Hansen commented on patch set 4 03/08/21, 17:39

    AbstractExceptionHandler.php:42 Reply

    Done
  17. TYPO3com voted on patch set 4 V +1 03/08/21, 17:45 Completed build in 06m 25s on Mon, 8 Mar, 05:45 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9938

  18. core-ci voted on patch set 4 V +1 03/08/21, 17:49 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1282

  19. Richard Haeser voted on patch set 4 CR +1 03/25/21, 13:18

  20. Mathias Brodala voted on patch set 4 CR +1 03/25/21, 13:50

  21. Benni Mack voted on patch set 4 V +1 CR +1 04/06/21, 13:57

  22. Josef Glatz voted on patch set 4 V +1 CR +1 04/06/21, 14:48

  23. Oli Bartsch voted on patch set 4 CR +1 04/06/21, 15:36

  24. Anja Leichsenring voted on patch set 4 V +2 CR +2 04/06/21, 16:27

  25. Anja Leichsenring merged patch set 5 04/06/21, 16:28