Review main Merged

68201[TASK] Decouple PageTree from NavigationComponent

Benni Mack CR +2 V +2 Hard +248 −268 updated 03/08/21, 09:15

Commit message

In order to use the non-iframe navigation component properly,
the current ties to "PageTree" (which was de-facto the only possible
navigation component to be used until TYPO3 v11 due to heavy
coupling) are removed.

The TreeInterface, which served as a wrapper for the PageTree
Navigation Component is removed, and replaced by the NavigationComponent
interface in TypeScript.

In addition, loading and initializing (and keeping state) of the
used navigation component now solely relies in the NavigationContainer.

This in turn, finally allows to e.g. properly re-load the FileStorageTree
and PageTree separately (see BackendUtility change) while
incorporating some ES6 nullable functionality.

In addition, the NavigationContainer is now jQuery-free.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 31

Show 11 more files

Review log 919

  1. Benni Mack uploaded patch set 1 03/06/21, 21:59

  2. TYPO3com voted on patch set 1 V +1 03/06/21, 22:06 Completed build in 07m 12s on Sat, 6 Mar, 10:06 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9888

  3. core-ci voted on patch set 1 V +1 03/06/21, 22:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1227

  4. Benni Mack uploaded patch set 2 03/06/21, 22:26

  5. TYPO3com voted on patch set 2 V -1 03/06/21, 22:33 Completed build in 06m 41s on Sat, 6 Mar, 10:33 PM Test Summary: 36 of 32986 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9889

  6. Benni Mack uploaded patch set 3 03/06/21, 22:33

  7. core-ci voted on patch set 2 V -1 03/06/21, 22:41 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1228

  8. TYPO3com voted on patch set 3 V +1 03/06/21, 22:41 Completed build in 07m 23s on Sat, 6 Mar, 10:41 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9890

  9. core-ci voted on patch set 3 V +1 03/06/21, 22:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1229

  10. Benni Mack uploaded patch set 4 03/07/21, 00:19

  11. TYPO3com commented on patch set 4 03/07/21, 00:26 Completed build in 06m 43s on Sun, 7 Mar, 12:26 AM Test Summary: 32743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9892

  12. core-ci commented on patch set 4 03/07/21, 00:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1231

  13. Benni Mack uploaded patch set 5 03/07/21, 19:59

  14. TYPO3com commented on patch set 5 03/07/21, 20:06 Completed build in 06m 57s on Sun, 7 Mar, 08:06 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9906

  15. core-ci commented on patch set 5 03/07/21, 20:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1248

  16. Richard Haeser voted on patch set 5 V +1 CR +1 03/08/21, 08:56

  17. Christian Kuhn voted on patch set 5 CR +1 03/08/21, 09:12

  18. Christian Kuhn voted on patch set 5 V +2 CR +2 03/08/21, 09:14

  19. Christian Kuhn merged patch set 6 03/08/21, 09:15