68233[TASK] Refactor PageTree and FileStorage into custom HTMLElements
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Richard Haeser +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 25
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTree.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeElement.ts2+111 −105
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/FileStorageTreeContainer.ts+80 −81
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationComponent.tsdeleted+0 −28
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationContainer.ts2+26 −25
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/AjaxDataHandler.ts+1 −3
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenuActions.ts+18 −12
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageActions.ts+1 −1
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/Recordlist.ts+1 −1
- Build/Sources/TypeScript/recycler/Resources/Public/TypeScript/Recycler.ts+1 −3
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Toolbar/WorkspacesMenu.ts+1 −3
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts+1 −3
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+4 −4
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+10 −8
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/FileStorageTreeContainer.js+8 −6
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/NavigationComponent.jsdeleted+0 −13
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/NavigationContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/AjaxDataHandler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
Show 5 more files
- typo3/sysext/backend/Resources/Public/JavaScript/PageActions.js+1 −1
- typo3/sysext/recordlist/Resources/Public/JavaScript/Recordlist.js+1 −1
- typo3/sysext/recycler/Resources/Public/JavaScript/Recycler.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Toolbar/WorkspacesMenu.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −1
Review log 1943
Show 618 earlier messages
-
Benni Mack uploaded patch set 1 03/07/21, 19:59
-
TYPO3com voted on patch set 1 V -1 03/07/21, 20:00 Completed build in 17s on Sun, 7 Mar, 08:00 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9907
-
core-ci voted on patch set 1 V -1 03/07/21, 20:16 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1249
-
Benni Mack uploaded patch set 2 03/08/21, 10:07
-
TYPO3com voted on patch set 2 V -1 03/08/21, 10:13 Completed build in 05m 56s on Mon, 8 Mar, 10:13 AM Test Summary: 33 of 32986 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9919
-
core-ci voted on patch set 2 V -1 03/08/21, 10:20 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1264
-
Benni Mack uploaded patch set 3 03/08/21, 16:28
-
TYPO3com voted on patch set 3 V -1 03/08/21, 16:33 Completed build in 05m 43s on Mon, 8 Mar, 04:33 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9934
-
core-ci voted on patch set 3 V -1 03/08/21, 16:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1278
-
Benni Mack uploaded patch set 4 03/08/21, 16:58
-
TYPO3com voted on patch set 4 V +1 03/08/21, 17:04 Completed build in 05m 47s on Mon, 8 Mar, 05:04 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9935
-
core-ci voted on patch set 4 V -1 03/08/21, 17:08 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1279
-
Benni Mack uploaded patch set 5 03/09/21, 08:35
-
TYPO3com voted on patch set 5 V +1 03/09/21, 08:41 Completed build in 05m 48s on Tue, 9 Mar, 08:41 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9957
-
core-ci voted on patch set 5 V -1 03/09/21, 08:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1305
-
Benjamin Franzke uploaded patch set 6 03/09/21, 09:43
-
TYPO3com voted on patch set 6 V +1 03/09/21, 09:50 Completed build in 06m 07s on Tue, 9 Mar, 09:50 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9958
-
core-ci voted on patch set 6 V +1 03/09/21, 09:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1309
-
Benjamin Franzke uploaded patch set 7 03/09/21, 10:01
-
TYPO3com voted on patch set 7 V +1 03/09/21, 10:08 Completed build in 07m 04s on Tue, 9 Mar, 10:08 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9959
-
core-ci voted on patch set 7 V +1 03/09/21, 10:13 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1310
-
Benni Mack updated the commit message in patch set 8 03/09/21, 11:16
-
TYPO3com voted on patch set 8 V +1 03/09/21, 11:22 Completed build in 05m 48s on Tue, 9 Mar, 11:22 AM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9960
-
core-ci voted on patch set 8 V +1 03/09/21, 11:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1312
-
Benjamin Franzke commented on patch set 8 CR -1 03/09/21, 11:31
NavigationContainer.ts:63As a new solid interface I would additionally like to use somethign like __esModule.navigationComponentName instead of relying of a magic "first" export. Will try to change this. -
Benjamin Franzke uploaded patch set 9 03/09/21, 13:07
-
TYPO3com voted on patch set 9 V +1 03/09/21, 13:13 Completed build in 05m 08s on Tue, 9 Mar, 01:13 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9965
-
core-ci voted on patch set 9 V +1 03/09/21, 13:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1318
-
Benjamin Franzke uploaded patch set 10 03/09/21, 13:35
-
Benjamin Franzke commented on patch set 10 03/09/21, 13:35
PageTreeElement.ts:75ReplyMarked as todo.NavigationContainer.ts:63ReplyDone -
TYPO3com voted on patch set 10 V +1 03/09/21, 13:41 Completed build in 06m 21s on Tue, 9 Mar, 01:41 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9966
-
core-ci voted on patch set 10 V +1 03/09/21, 13:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1320
-
Richard Haeser commented on patch set 10 V -1 03/09/21, 13:54
It is not possible to filter the file tree at the moment. Not yet checked out what change caused this issue. Uncaught TypeError: Cannot read property 'node' of null at nodesAddPlaceholder (SvgTree.js?bust=1615297954:13) at n.filterTree (FileStorageTree.js?bust=1615297954:13) at n.refreshOrFilterTree (FileStorageTree.js?bust=1615297954:13) at HTMLElement.search (FileStorageTreeContainer.js?bust=1615297954:40) at HTMLInputElement.<anonymous> (FileStorageTreeContainer.js?bust=1615297954:29) at DebounceEvent.js?bust=1615297954:13 -
Benni Mack rebased onto patch set 11 03/09/21, 14:13
-
TYPO3com voted on patch set 11 V +1 03/09/21, 14:20 Completed build in 06m 50s on Tue, 9 Mar, 02:20 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9969
-
Benni Mack uploaded patch set 12 03/09/21, 14:20
-
Richard Haeser voted on patch set 12 V +1 CR +1 03/09/21, 14:24
-
core-ci voted on patch set 11 V +1 03/09/21, 14:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1323
-
TYPO3com voted on patch set 12 V +1 03/09/21, 14:27 Completed build in 06m 16s on Tue, 9 Mar, 02:27 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9971
-
Benjamin Franzke voted on patch set 12 CR +1 03/09/21, 14:30
-
core-ci voted on patch set 12 V +1 03/09/21, 14:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1325
-
Benjamin Franzke voted on patch set 12 V +2 CR +2 03/09/21, 14:31
-
Benjamin Franzke merged patch set 13 03/09/21, 14:32
PageTreeElement.ts:75