Review main Merged

68234[TASK] Fix PHP 8 compatibility issues part 3/x

Christian Kuhn CR +2 V +2 Normal +94 −47 updated 03/08/21, 09:38

Commit message

PHP 8 throws warning level errors instead of
notice level errors when an not existing array
key is accessed.
The patch fixes another batch of this kind of
issues found by functional tests.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Jochen Roth +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 11

Review log 1224

  1. Christian Kuhn uploaded patch set 1 03/07/21, 21:55

  2. Christian Kuhn uploaded patch set 2 03/07/21, 21:58

  3. TYPO3com voted on patch set 1 V +1 03/07/21, 22:02 Completed build in 07m 41s on Sun, 7 Mar, 10:02 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9910

  4. core-ci voted on patch set 1 V +1 03/07/21, 22:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1252

  5. TYPO3com voted on patch set 2 V -1 03/07/21, 22:07 Completed build in 08m 40s on Sun, 7 Mar, 10:07 PM Test Summary: 32743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9911

  6. Christian Kuhn uploaded patch set 3 03/07/21, 22:55

  7. TYPO3com voted on patch set 3 V -1 03/07/21, 23:01 Completed build in 06m 46s on Sun, 7 Mar, 11:01 PM Test Summary: 3 of 32986 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9912

  8. Christian Kuhn uploaded patch set 4 03/07/21, 23:06

  9. TYPO3com voted on patch set 4 V -1 03/07/21, 23:14 Completed build in 07m 19s on Sun, 7 Mar, 11:14 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9913

  10. Christian Kuhn uploaded patch set 5 03/07/21, 23:24

  11. TYPO3com voted on patch set 5 V +1 03/07/21, 23:31 Completed build in 06m 33s on Sun, 7 Mar, 11:31 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9914

  12. core-ci voted on patch set 5 V +1 03/07/21, 23:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1256

  13. core-ci voted on patch set 2 V -1 03/08/21, 00:02 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1253

  14. core-ci voted on patch set 3 V -1 03/08/21, 00:56 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1254

  15. core-ci voted on patch set 4 V -1 03/08/21, 01:08 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1255

  16. Jochen Roth voted on patch set 5 V +1 CR +1 03/08/21, 08:42

  17. Christian Kuhn commented on patch set 5 CR -1 03/08/21, 09:22

    i'll reset one file that looks fishy.
  18. Christian Kuhn uploaded patch set 6 03/08/21, 09:23

  19. Richard Haeser voted on patch set 6 V +1 CR +1 03/08/21, 09:25

  20. Jochen Roth voted on patch set 6 V +1 CR +1 03/08/21, 09:27

  21. TYPO3com voted on patch set 6 V +1 03/08/21, 09:30 Completed build in 06m 44s on Mon, 8 Mar, 09:30 AM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9917

  22. core-ci voted on patch set 6 V +1 03/08/21, 09:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1262

  23. Richard Haeser voted on patch set 6 V +2 CR +2 03/08/21, 09:38

  24. Richard Haeser merged patch set 7 03/08/21, 09:38