Review main Merged

68253[TASK] DataHandler: Drop a series of unused method arguments

Christian Kuhn CR +2 V +2 Easy +11 −18 updated 03/14/21, 17:54

Commit message

Update some simple cases in DataHandler where
method arguments are provided, but not used.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 918

  1. Christian Kuhn uploaded patch set 1 03/08/21, 13:37

  2. TYPO3com voted on patch set 1 V -1 03/08/21, 13:45 Completed build in 08m 00s on Mon, 8 Mar, 01:45 PM Test Summary: 1 of 32986 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9928

  3. core-ci voted on patch set 1 V +1 03/08/21, 13:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1272

  4. TYPO3com voted on patch set 1 V +1 03/08/21, 13:50 Completed build in 21m 22s on Mon, 8 Mar, 01:50 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9928

  5. Christian Kuhn updated the commit message in patch set 2 03/08/21, 13:52

  6. TYPO3com voted on patch set 2 V +1 03/08/21, 13:59 Completed build in 06m 29s on Mon, 8 Mar, 01:59 PM Test Summary: 32745 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9930

  7. core-ci voted on patch set 2 V +1 03/08/21, 14:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1274

  8. Oliver Klee updated the commit message in patch set 3 03/08/21, 14:23

  9. TYPO3com voted on patch set 3 V +1 03/08/21, 14:30 Completed build in 06m 23s on Mon, 8 Mar, 02:30 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9931

  10. core-ci voted on patch set 3 V +1 03/08/21, 14:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1275

  11. Benni Mack commented on patch set 3 03/08/21, 16:33

    DataHandler.php:5776

    this sounds like it could be a bug that we don't consider the table?
  12. Christian Kuhn commented on patch set 3 03/08/21, 17:36

    DataHandler.php:5776 Reply Unresolved

    i have no idea ... we need to dig into mm stuff anyways. i'll reset this hunk for now.
  13. Christian Kuhn uploaded patch set 4 03/08/21, 17:39

  14. TYPO3com voted on patch set 4 V +1 03/08/21, 17:47 Completed build in 07m 28s on Mon, 8 Mar, 05:47 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9939

  15. core-ci voted on patch set 4 V +1 03/08/21, 17:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1283

  16. Anja Leichsenring voted on patch set 4 V +1 CR +1 03/14/21, 15:37

  17. Benni Mack commented on patch set 4 V +2 CR +2 03/14/21, 17:54

    thx!
  18. Benni Mack merged patch set 5 03/14/21, 17:54