Review main Merged

68254[BUGFIX] Avoid loading console commands before container is current

Benjamin Franzke CR +2 V +2 Easy +28 −11 updated 03/10/21, 10:01

Commit message

The shortcut handling added in #86248 caused the matching command
to be loaded before the symfony DI container was made available to
GeneralUtility::makeInstance (FailsafeContainer was still active).
This caused services (e.g in #93442) that are instantiated using the
GeneralUtility::makeInstance-to-DI-Container bridge to fail
as these services are not available in the FailsafeContainer.

Background: the symfony Application:find() method did not just
search for a matching command, but it also initialized it, once found.
Therefore shortcut resolving is now handled within the TYPO3 command
application to ensure commands are only instantiated once the
symfony container (and localconf) is fully loaded.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Andreas Kienast +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 3

Files 1

Review log 816

  1. Benjamin Franzke uploaded patch set 1 03/08/21, 17:23

  2. Benjamin Franzke rebased onto patch set 2 03/08/21, 17:24

  3. TYPO3com voted on patch set 1 V +1 03/08/21, 17:30 Completed build in 06m 33s on Mon, 8 Mar, 05:30 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9936

  4. TYPO3com voted on patch set 2 V +1 03/08/21, 17:31 Completed build in 06m 42s on Mon, 8 Mar, 05:31 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9937

  5. core-ci voted on patch set 1 V +1 03/08/21, 17:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1280

  6. core-ci voted on patch set 2 V +1 03/08/21, 17:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1281

  7. Benjamin Franzke uploaded patch set 3 03/08/21, 19:33

  8. TYPO3com voted on patch set 3 V -1 03/08/21, 19:39 Completed build in 06m 18s on Mon, 8 Mar, 07:39 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9940

  9. core-ci voted on patch set 3 V -1 03/08/21, 19:46 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1284

  10. Benjamin Franzke uploaded patch set 4 03/08/21, 19:57

  11. core-ci voted on patch set 4 V +1 03/08/21, 20:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1289

  12. TYPO3com voted on patch set 4 V +1 03/08/21, 20:14 Completed build in 16m 27s on Mon, 8 Mar, 08:14 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9944

  13. Andreas Kienast voted on patch set 4 V +1 03/08/21, 21:36

  14. Benni Mack voted on patch set 4 V +1 CR +1 03/10/21, 08:33

  15. Helmut Hummel voted on patch set 4 V +2 CR +2 03/10/21, 10:01

  16. Helmut Hummel merged patch set 5 03/10/21, 10:01