Review main Merged

68256[TASK] Update to psr/container v1.1

Benjamin Franzke CR +2 V +2 Easy +13 −18 updated 03/08/21, 21:42

Commit message

The v1.1 interface adds support for parameter
type declarations.

Also mark as psr/container v2 compatible as we add
the `bool` return type annoation for `has()` right away.
(yes that is compatible with the v1.1 interface,
although it doesn't contain a return type declaration)

This is not yet testable against psr/container v2,
but will show up in nightly composer-max stages
once symfony/dependency-injection is released
with support for psr/container v2.

Commands used:
  composer require "psr/container:^1.1 || ^2.0"
  composer require "psr/container:^1.1 || ^2.0" \
    --no-update -d typo3/sysext/core

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 612

  1. Benjamin Franzke uploaded patch set 1 03/08/21, 20:25

  2. TYPO3com voted on patch set 1 V +1 03/08/21, 20:31 Completed build in 05m 45s on Mon, 8 Mar, 08:31 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9945

  3. core-ci voted on patch set 1 V +1 03/08/21, 20:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1290

  4. Benjamin Franzke uploaded patch set 2 03/08/21, 20:35

  5. Benjamin Franzke updated the commit message in patch set 3 03/08/21, 20:39

  6. TYPO3com voted on patch set 2 V +1 03/08/21, 20:43 Completed build in 07m 14s on Mon, 8 Mar, 08:43 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9946

  7. TYPO3com voted on patch set 3 V +1 03/08/21, 20:45 Completed build in 06m 16s on Mon, 8 Mar, 08:45 PM Test Summary: 32638 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9947

  8. core-ci voted on patch set 2 V +1 03/08/21, 20:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1291

  9. core-ci voted on patch set 3 V +1 03/08/21, 20:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1292

  10. Andreas Kienast voted on patch set 3 V +1 CR +1 03/08/21, 21:27

  11. Benni Mack voted on patch set 3 V +2 CR +2 03/08/21, 21:42

  12. Benni Mack merged patch set 4 03/08/21, 21:42